1. 23 Jan, 2014 4 commits
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · f0de3b80
      m.pakula@samsung.com authored
      Update test expectations for failing or crashing http/tests/websocket/tests/hybi tests.
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0de3b80
    • commit-queue@webkit.org's avatar
      [CSS Regions] Fix positioning composited layers when the region has overflow:hidden · 4affaa08
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124042
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2014-01-23
      Reviewed by Mihnea Ovidenie.
      
      Source/WebCore:
      
      If there's a clipping GraphicsLayer on the hierarchy, substract its offset, since it's its
      parent that positions us.
      
      Tests: compositing/regions/position-layer-inside-region-overflow-hidden.html
             compositing/regions/position-layer-inside-overflow-hidden.html
             compositing/regions/position-layers-inside-region-overflow-hidden.html
             compositing/regions/position-layers-inside-regions-overflow-hidden.html
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): The position
      must also be correct when the region has box-shadow that inflates the region's layer. The
      composited layers from the flow thread should be rendered in the same position whether the
      associated region has clipping or not.
      Using the position of the clipping layer instead of the location of the clipbox makes it
      also work with box-shadow that inflates the region's graphics layer.
      
      LayoutTests:
      
      * compositing/regions/position-layer-inside-region-overflow-hidden.html: Added.
      * compositing/regions/position-layer-inside-region-overflow-hidden-expected.html: Added.
      * compositing/regions/position-layer-inside-overflow-hidden.html: Added.
      * compositing/regions/position-layer-inside-overflow-hidden-expected.html: Added.
      * compositing/regions/position-layers-inside-region-overflow-hidden.html: Added.
      * compositing/regions/position-layers-inside-region-overflow-hidden-expected.html: Added.
      * compositing/regions/position-layers-inside-regions-overflow-hidden.html: Added.
      * compositing/regions/position-layers-inside-regions-overflow-hidden-expected.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4affaa08
    • ossy@webkit.org's avatar
      Unreviewed gardening. · a18f28e1
      ossy@webkit.org authored
      Move fast/harness/sample-fail-mismatch-reftest.html to the platform
      independent TestExpectations, since all ports skip it as expected.
      
      * TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a18f28e1
    • commit-queue@webkit.org's avatar
      Range should be constructable. · e6c09a97
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115639
      
      Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-23
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      http://www.w3.org/TR/2013/WD-dom-20131107/#interface-range
      Now we can do `new Range()` instead of `document.createRange()`.
      
      Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/47ca40efdf58a4787aa33aa75a35778899b1c002%5E%21
      
      Test: fast/dom/Range/range-constructor.html
      
      * dom/Range.cpp:
      (WebCore::Range::create):
      * dom/Range.h:
      * dom/Range.idl:
      
      LayoutTests:
      
      * fast/dom/Range/range-constructor-expected.txt: Added.
      * fast/dom/Range/range-constructor.html: Added.
      * fast/dom/dom-constructors-expected.txt:
      * fast/dom/dom-constructors.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6c09a97
  2. 22 Jan, 2014 16 commits
    • jinwoo7.song@samsung.com's avatar
      Unreviewed EFL gardening after r162553. · a59aad63
      jinwoo7.song@samsung.com authored
      * platform/efl/css1/box_properties/padding-expected.txt:
      * platform/efl/css1/box_properties/padding_top-expected.txt:
      * platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
      * platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
      * platform/efl/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
      * platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
      * platform/efl/fast/css/empty-pseudo-class-expected.txt:
      * platform/efl/fast/css/fieldset-display-row-expected.txt:
      * platform/efl/fast/css/first-child-pseudo-class-expected.txt:
      * platform/efl/fast/css/last-child-pseudo-class-expected.txt:
      * platform/efl/fast/css/only-child-pseudo-class-expected.txt:
      * platform/efl/fast/repaint/reflection-redraw-expected.txt:
      * platform/efl/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
      * platform/efl/fast/table/multiple-captions-display-expected.txt:
      * platform/efl/tables/mozilla/marvin/body_col-expected.txt:
      * platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
      * platform/efl/tables/mozilla/other/body_col-expected.txt:
      * platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
      * platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
      * platform/efl/tables/mozilla_expected_failures/core/captions3-expected.txt:
      * platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a59aad63
    • mmaxfield@apple.com's avatar
      ASSERTION FAILED: v.isFixed() in WebCore::RenderStyle::setWordSpacing · 494da149
      mmaxfield@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126987
      
      Reviewed by Simon Fraser.
      
      When "inherit" is specified and there is no parent, Length values have an "Auto" type
      
      Source/WebCore:
      
      Test: fast/css3-text/css3-word-spacing-percentage/word-spacing-crash.html
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::setWordSpacing):
      
      LayoutTests:
      
      * fast/css3-text/css3-word-spacing-percentage/word-spacing-crash-expected.txt: Added.
      * fast/css3-text/css3-word-spacing-percentage/word-spacing-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      494da149
    • samuel_white@apple.com's avatar
      AX: Can't always increment web sliders. · 24dac231
      samuel_white@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127451
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Clamping the decrement/increment amount to one when necessary (if a percent change would result in a change of less than one).
      
      Test: accessibility/range-alter-by-percent.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::changeValueByPercent):
      
      LayoutTests:
      
      Adding range-alter-by-percent.html to compliment the existing range-alter-by-step.html test.
      
      * accessibility/range-alter-by-percent-expected.txt: Added.
      * accessibility/range-alter-by-percent.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24dac231
    • cfleizach@apple.com's avatar
      Source/WebCore: AX: Do not return an accessible name for an object just because it has tabindex=0 · 7f23b89a
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126914
      
      Reviewed by Mario Sanchez Prada.
      
      WebKit has code to return an accessible name for any object that is "generically" focusable (ie. tabindex=0).
      This behavior, which is not supported in ARIA, has caused many problems for VoiceOver. Often VoiceOver will
      speak all the text underneath any type of group.
      
      I think we need to revert this behavior and follow the ARIA spec more closely.
      
      Test: accessibility/aria-describedby-ensures-visibility.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::visibleText):
      (WebCore::AccessibilityNodeObject::title):
      
      LayoutTests: AX: WebKit concatenates name of all toolbar buttons in the apple.com video player
      https://bugs.webkit.org/show_bug.cgi?id=126914
      
      Reviewed by Mario Sanchez Prada.
      
      * accessibility/focusable-div-expected.txt:
      * accessibility/focusable-div.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f23b89a
    • dino@apple.com's avatar
      Source/WebCore: [WebGL] Implement ANGLE_instanced_arrays · 81d4ed94
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127257
      
      Reviewed by Brent Fulgham.
      
      Implement the instanced drawing WebGL extension,
      ANGLE_instanced_arrays. This is currently Mac-only,
      but should be portable to other platforms if their
      OpenGL exposes the functions. It's also done in a way
      that will make exposing it to WebGL2 simple.
      
      Test: fast/canvas/webgl/angle-instanced-arrays.html
      
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      Add the new files to all the build systems.
      
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::toJS): Link JS side to C++ side.
      
      * html/canvas/ANGLEInstancedArrays.cpp: Added.
      (WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):
      * html/canvas/ANGLEInstancedArrays.h: Added.
      * html/canvas/ANGLEInstancedArrays.idl: Added.
      New boilerplate files that expose the extension methods.
      
      * html/canvas/WebGLExtension.h: New extension enum.
      
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::validateVertexAttributes): Add an optional
      parameter representing the number of instance primitives we are asked
      to draw. Use that for the draw count if looking at an instanced attribute.
      Also make sure we see at least one non-instanced attribute.
      (WebCore::WebGLRenderingContext::validateDrawArrays): Update this so it could
      be used from either drawArrays or drawArraysInstanced.
      (WebCore::WebGLRenderingContext::drawArrays):
      (WebCore::WebGLRenderingContext::validateDrawElements): Same here, now can be
      used by the instanced and non-instanced versions.
      (WebCore::WebGLRenderingContext::drawElements):
      (WebCore::WebGLRenderingContext::getExtension): Create and return the new extension.
      (WebCore::WebGLRenderingContext::getSupportedExtensions): Add new extension to the list.
      (WebCore::WebGLRenderingContext::getVertexAttrib): Intercept a query to the divisor
      attribute and return the value we kept in the state.
      (WebCore::WebGLRenderingContext::drawArraysInstanced): Call the GC3D method.
      (WebCore::WebGLRenderingContext::drawElementsInstanced): Ditto.
      (WebCore::WebGLRenderingContext::vertexAttribDivisor): Ditto.
      
      * html/canvas/WebGLRenderingContext.h: Define the new methods and parameters.
      
      * html/canvas/WebGLVertexArrayObjectOES.cpp:
      (WebCore::WebGLVertexArrayObjectOES::setVertexAttribDivisor): Keep a record of the
      divisor if we set it.
      * html/canvas/WebGLVertexArrayObjectOES.h:
      (WebCore::WebGLVertexArrayObjectOES::VertexAttribState::VertexAttribState):
      
      * platform/graphics/GraphicsContext3D.h: New enum.
      * platform/graphics/mac/GraphicsContext3DMac.mm:
      (WebCore::GraphicsContext3D::drawArraysInstanced): The actual calls into OpenGL.
      (WebCore::GraphicsContext3D::drawElementsInstanced): Ditto.
      (WebCore::GraphicsContext3D::vertexAttribDivisor): Ditto.
      
      * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Empty implementations
      for non-mac platforms.
      
      * platform/graphics/ios/GraphicsContext3DIOS.h: Define the iOS names for the
      functions.
      
      LayoutTests: Implement ANGLE_instanced_arrays
      https://bugs.webkit.org/show_bug.cgi?id=127257
      
      Reviewed by Brent Fulgham.
      
      Copied a slightly modified version of the Khronos instanced
      arrays test (mostly modified due to the fact this comes from
      an in-progress update to the test suite).
      
      * fast/canvas/webgl/angle-instanced-arrays-expected.txt: Added.
      * fast/canvas/webgl/angle-instanced-arrays.html: Added.
      * fast/canvas/webgl/resources/webgl-test-utils.js:
      (WebGLTestUtils): Added some new functions that were missing, and
      some output to a checkColor test.
      * platform/efl/TestExpectations: Skip this for EFL.
      * platform/mac-mountainlion/fast/canvas/webgl/angle-instanced-arrays-expected.txt: Not
      supported on Mountain Lion.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d4ed94
    • zalan@apple.com's avatar
      Unreviewed Apple Windows port gardering after r162553. · 72cce00c
      zalan@apple.com authored
      * platform/win/fast/repaint/reflection-redraw-expected.txt: Added.
      * platform/win/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
      * platform/win/fast/table/multiple-captions-display-expected.txt: Added.
      * platform/win/tables/mozilla/marvin/body_col-a-expected.txt: Added.
      * platform/win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt: Added.
      * platform/win/tables/mozilla/other/body_col-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72cce00c
    • zalan@apple.com's avatar
      [CSS Shapes] shape-inside rectangle layout can fail · 588b6e43
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124784
      
      Reviewed by Darin Adler.
      
      Early subpixel rounding/flooring/ceiling can have unwanted
      side effect on the final pixel value. Delay pixel
      conversions as much as possible.
      
      Existing test is changed to reflect subpixel functionality.
      
      Source/WebCore:
      
      * rendering/shapes/RectangleShape.cpp:
      (WebCore::RectangleShape::firstIncludedIntervalLogicalTop):
      
      LayoutTests:
      
      * fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html:
      * platform/mac/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      588b6e43
    • zalan@apple.com's avatar
      Subpixel Layout: SimpleLineLayout needs more position rounding to match InlineFlowBox layout. · cb83ac5c
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127404
      
      Reviewed by Antti Koivisto.
      
      In order to produce a CSS pixel perfect layout, SimpleLineLayout needs to
      round line positions to CSS (integral) position similarly to InlineFlowBox.
      
      Source/WebCore:
      
      Existing tests cover it.
      
      * rendering/SimpleLineLayoutResolver.h:
      (WebCore::SimpleLineLayout::RunResolver::Run::rect):
      (WebCore::SimpleLineLayout::RunResolver::Run::baseline):
      
      LayoutTests:
      
      * platform/mac/css1/box_properties/padding-expected.txt:
      * platform/mac/css1/box_properties/padding_top-expected.txt:
      * platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
      * platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
      * platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
      * platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
      * platform/mac/fast/css/empty-pseudo-class-expected.txt:
      * platform/mac/fast/css/fieldset-display-row-expected.txt:
      * platform/mac/fast/css/first-child-pseudo-class-expected.txt:
      * platform/mac/fast/css/last-child-pseudo-class-expected.txt:
      * platform/mac/fast/css/only-child-pseudo-class-expected.txt:
      * platform/mac/fast/repaint/reflection-redraw-expected.txt:
      * platform/mac/fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.png: Removed.
      * platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
      * platform/mac/fast/table/multiple-captions-display-expected.txt:
      * platform/mac/tables/mozilla/marvin/body_col-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
      * platform/mac/tables/mozilla/other/body_col-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb83ac5c
    • ap@apple.com's avatar
      REGRESSION: fast/js/dfg-* typed array tests frequently time out on debug bots · 6e2fdd9e
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126166
      
      Rubber-stamped by Filip Pizlo.
      
      * TestExpectations: Skipped these tests in debug builds.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e2fdd9e
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 2a003201
      m.pakula@samsung.com authored
      Add some http/tests/websocket/tests/hybi tests to skipped list as they crash
      generating thousands lines of error messages.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a003201
    • commit-queue@webkit.org's avatar
      [CSS Background Blending] -webkit-background-blend-mode fails for certain SVG files · 15e35e7a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127350
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-22
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      The graphics context of the SVG inherits the blend mode set
      on the background layer. Fix consists in drawing the SVG
      in a transparency layer.
      
      Test: css3/compositing/background-blend-mode-svg.html
      
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::draw): Begin a transparency layer if a blend mode is set.
      
      LayoutTests:
      
      * css3/compositing/background-blend-mode-svg-expected.html: Added.
      * css3/compositing/background-blend-mode-svg.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15e35e7a
    • antti@apple.com's avatar
      Update overlay scrollbars in single pass · df985172
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127289
      
      Source/WebCore: 
      
      Reviewed by Anders Carlsson.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars):
              
          Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.
      
      LayoutTests: 
      
      * platform/mac/accessibility/iframe-aria-hidden.html: 
              
          Try to keep this non-flaky by forcing layout. Real fix would probably be in the
          accessibility test framework.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df985172
    • changseok.oh@collabora.com's avatar
      Unreviewed GTK gardening · 3de29efe
      changseok.oh@collabora.com authored
      Remove test expectations for passed tests.
      fast/parser/document-write-basic.html is marked crash but passed.
      fast/forms/select-live-pseudo-selectors.html is marked crash but passed.
      
      * platform/gtk-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3de29efe
    • ap@apple.com's avatar
      inspector-protocol/page/deny-X-FrameOption.html is very flaky · b907d704
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127414
      
      * inspector-protocol/page/deny-X-FrameOption.html: Speculative fix, don't manipulate
      a frame before onload, even if it's empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b907d704
    • mihnea@adobe.com's avatar
      [CSSRegions] Incorrect layout of a region pseudo children · 4ebf1ec1
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126146
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Test: fast/regions/collapse-anonymous-region.html
      
      A region behaviour, styled using -webkit-flow-from, is modeled using an anonymous
      block created to fragment the named flow content inside the region. We have to prevent
      the behaviour of anonymous children collapsing for this block to make sure that the
      region element children are still laid out properly when the region element becomes an ordinary
      element.
      
      * rendering/RenderBlockFlow.h:
      
      LayoutTests:
      
      * fast/regions/collapse-anonymous-region-expected.html: Added.
      * fast/regions/collapse-anonymous-region.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ebf1ec1
    • ryuan.choi@samsung.com's avatar
      Remove unused "acceleratedCompositingForScrollableFramesEnabled" setting · 624f11dd
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127402
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      compositing/iframes/iframe-composited-scrolling.html is updated because
      there are no usages in WebCore.
      
      * page/Settings.in:
      
      LayoutTests:
      
      * compositing/iframes/iframe-composited-scrolling.html:
      Removed acceleratedCompositingForScrollableFramesEnabled changes because
      it is dead code in WebCore side.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      624f11dd
  3. 21 Jan, 2014 12 commits
  4. 20 Jan, 2014 8 commits
    • zalan@apple.com's avatar
      Change image failures from [ Failure ] to [ ImageOnlyFailure ] where needed. · 64d1e069
      zalan@apple.com authored
      * platform/mac/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64d1e069
    • zalan@apple.com's avatar
      Add missing expectations to subpixel failures. · de5f2d3a
      zalan@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de5f2d3a
    • ap@apple.com's avatar
      platform/mac/accessibility/iframe-aria-hidden.html is flaky · 067afd26
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127323
      
      * platform/mac-wk2/TestExpectations: Marked as such.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      067afd26
    • ap@apple.com's avatar
      Fix an erroneous paste in TestExpectations. · f9ad2c92
      ap@apple.com authored
      * platform/mac-wk2/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9ad2c92
    • ap@apple.com's avatar
      svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html is flaky · 070c2097
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127316
      
      * platform/mac-wk2/TestExpectations: Marked as such.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      070c2097
    • zalan@apple.com's avatar
      Subpixel layout: 100000px overflows while calculating layout positions. · ef291d28
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126896
      
      Reviewed by Simon Fraser.
      
      Test case is adjusted to subpixel layout.
      
      * fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
      * platform/efl/TestExpectations:
      * platform/gtk/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt: Removed.
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef291d28
    • ap@apple.com's avatar
      svg/filters/feComponentTransfer-style-crash.xhtml is flaky · 63e67ef5
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127310
      
      * platform/mac/TestExpectations: Marked it as such.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63e67ef5
    • commit-queue@webkit.org's avatar
      Region based multicol: support explicit column breaks · fd8f1a2d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123993
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Merely supporting insertion of explicit (forced) column breaks in
      the region based multicol implementation is really simple: just
      hook up with what the CSS regions code is already doing.
      
      However, there is one complication: column balancing. In order to
      balance columns as nicely as possible when there are explicit
      breaks, we need to figure out between which explicit breaks the
      implicit breaks will occur (if there's room for any at all).
      
      Tests: fast/multicol/newmulticol/break-after.html
             fast/multicol/newmulticol/break-before.html
             fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html
             fast/multicol/newmulticol/breaks-2-columns-3.html
             fast/multicol/newmulticol/breaks-3-columns-3.html
             fast/multicol/newmulticol/fixed-height-fill-balance-2.html
      
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::applyBeforeBreak):
      (WebCore::RenderBlockFlow::applyAfterBreak): Use the already
      existing region breaking code when inserting breaks in region
      based multicol.
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnBlock.cpp:
      (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
      (WebCore::RenderMultiColumnBlock::relayoutForPagination): Avoid
      re-balancing if the multicol's contents were not laid out. Apart
      from being good for performance, this is now necessary because of
      how explicit breaks are implemented.
      (WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
      Detect if the contents are going to be laid out, or skipped, so
      that we can tell if we need to (re-)balance the columns
      afterwards.
      * rendering/RenderMultiColumnBlock.h:
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak):
      Locate the appropriate multi-column set and call its
      addForcedBreak().
      * rendering/RenderMultiColumnFlowThread.h:
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
      (WebCore::RenderMultiColumnSet::findRunWithTallestColumns):
      (WebCore::RenderMultiColumnSet::distributeImplicitBreaks): Figure
      out how many implicit breaks each single "content run" should
      contain. The taller the content run, the more implicit breaks.
      (WebCore::RenderMultiColumnSet::calculateBalancedHeight): This is
      now a const method that only does half of what the old
      calculateBalancedHeight() did. The rest (such as actually storing
      the new column height) is done by recalculateBalancedHeight().
      (WebCore::RenderMultiColumnSet::clearForcedBreaks): Needs to be
      called between each layout pass, to clear the list of "content
      runs".
      (WebCore::RenderMultiColumnSet::addForcedBreak): Only useful when
      columns are to be balanced. It receives explicit (forced) breaks
      and stores them as "content runs". When layout is done, we'll go
      through the list of content runs, and see where implicit breaks
      should be inserted (if there's room for any). The goal is to
      insert implicit breaks in such a way that the final columns become
      as short as possible.
      (WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
      Calculates and sets a new balanced column height. This used to be
      done directly in calculateBalancedHeight(), but that method is now
      const and it now only calculates the new height and returns it.
      (WebCore::RenderMultiColumnSet::prepareForLayout):
      * rendering/RenderMultiColumnSet.h: Remove old data members
      intended for forced breaks (they were unused), and introduce a
      "content run" vector instead. A new content run is triggered by an
      explicit break. This is only used when column balancing is
      enabled. When not balanced, RenderMultiColumnSet doesn't need to
      do anything when explicit breaks are inserted.
      
      LayoutTests:
      
      * fast/multicol/newmulticol/break-after-expected.html: Added.
      * fast/multicol/newmulticol/break-after.html: Added.
      * fast/multicol/newmulticol/break-before-expected.html: Added.
      * fast/multicol/newmulticol/break-before.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-expected.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-no-balancing-expected.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3.html: Added.
      * fast/multicol/newmulticol/breaks-3-columns-3-expected.html: Added.
      * fast/multicol/newmulticol/breaks-3-columns-3.html: Added.
      * fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html: Added.
      * fast/multicol/newmulticol/fixed-height-fill-balance-2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd8f1a2d