Commit 8b2c964a authored by cfleizach@apple.com's avatar cfleizach@apple.com

AX: Mac: Expose the visible text of a password field to AX

https://bugs.webkit.org/show_bug.cgi?id=127353

Reviewed by Brent Fulgham.

Source/WebCore:

The Mac platform should now expose the rendered value of password fields through AX.

Test: accessibility/password-field-value.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textLength):
(WebCore::AccessibilityRenderObject::passwordFieldValue):

LayoutTests:

* accessibility/password-field-value-expected.txt: Added.
* accessibility/password-field-value.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent c3f31ab5
2014-01-21 Chris Fleizach <cfleizach@apple.com>
AX: Mac: Expose the visible text of a password field to AX
https://bugs.webkit.org/show_bug.cgi?id=127353
Reviewed by Brent Fulgham.
* accessibility/password-field-value-expected.txt: Added.
* accessibility/password-field-value.html: Added.
2014-01-21 Tamas Gergely <tgergely.u-szeged@partner.samsung.com>
ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase
This tests that the AX exposed value of a password field is the rendered text.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Password field: AXValue: ••••
PASS successfullyParsed is true
TEST COMPLETE
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<script src="../../../resources/js-test-pre.js"></script>
</head>
<body id="body">
<input type="password" id="pass" value="test">
<p id="description"></p>
<div id="console"></div>
<script>
description("This tests that the AX exposed value of a password field is the rendered text.");
if (window.accessibilityController) {
debug("Password field: " + accessibilityController.accessibleElementById("pass").stringValue);
}
successfullyParsed = true;
</script>
<script src="../../../resources/js-test-post.js"></script>
</body>
</html>
2014-01-21 Chris Fleizach <cfleizach@apple.com>
AX: Mac: Expose the visible text of a password field to AX
https://bugs.webkit.org/show_bug.cgi?id=127353
Reviewed by Brent Fulgham.
The Mac platform should now expose the rendered value of password fields through AX.
Test: accessibility/password-field-value.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textLength):
(WebCore::AccessibilityRenderObject::passwordFieldValue):
2014-01-21 Robert Sipka <sipka@inf.u-szeged.hu>
Support SSL error handling in case of synchronous job.
......@@ -1393,11 +1393,7 @@ int AccessibilityRenderObject::textLength() const
ASSERT(isTextControl());
if (isPasswordField())
#if PLATFORM(GTK)
return passwordFieldValue().length();
#else
return -1; // need to return something distinct from 0
#endif
return text().length();
}
......@@ -3359,7 +3355,6 @@ AccessibilityRole AccessibilityRenderObject::roleValueForMSAA() const
String AccessibilityRenderObject::passwordFieldValue() const
{
#if PLATFORM(GTK)
ASSERT(isPasswordField());
// Look for the RenderText object in the RenderObject tree for this input field.
......@@ -3371,11 +3366,7 @@ String AccessibilityRenderObject::passwordFieldValue() const
return String();
// Return the text that is actually being rendered in the input field.
return static_cast<RenderText*>(renderer)->textWithoutConvertingBackslashToYenSymbol();
#else
// It seems only GTK is interested in this at the moment.
return String();
#endif
return toRenderText(renderer)->textWithoutConvertingBackslashToYenSymbol();
}
ScrollableArea* AccessibilityRenderObject::getScrollableAreaIfScrollable() const
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment