Skip to content
  • antti@apple.com's avatar
    https://bugs.webkit.org/show_bug.cgi?id=73954 · a40f8feb
    antti@apple.com authored
    REGRESSION (r97745): Transitions don't work on links
    
    Source/WebCore: 
    
    Reviewed by Andreas Kling.
    
    Test: transitions/visited-link-color.html
            
    Since visited link colors are now part of the RenderStyle, they need to be transitioned
    along with the corresponding regular colors.
    
    * page/animation/AnimationBase.cpp:
    (WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
    (WebCore::PropertyWrapperVisitedAffectedColor::equals):
    (WebCore::PropertyWrapperVisitedAffectedColor::blend):
    (WebCore::AnimationBase::ensurePropertyMap):
            
        Add new wrapper class that applies both regular and visited color.
            
    * rendering/style/RenderStyle.h:
    (WebCore::InheritedFlags::visitedLinkColor):
    (WebCore::InheritedFlags::visitedLinkBackgroundColor):
    (WebCore::InheritedFlags::visitedLinkBorderLeftColor):
    (WebCore::InheritedFlags::visitedLinkBorderRightColor):
    (WebCore::InheritedFlags::visitedLinkBorderBottomColor):
    (WebCore::InheritedFlags::visitedLinkBorderTopColor):
    (WebCore::InheritedFlags::visitedLinkOutlineColor):
    (WebCore::InheritedFlags::visitedLinkColumnRuleColor):
    (WebCore::InheritedFlags::visitedLinkTextEmphasisColor):
    (WebCore::InheritedFlags::visitedLinkTextFillColor):
    (WebCore::InheritedFlags::visitedLinkTextStrokeColor):
            
        Add accessors.
            
    * rendering/style/StyleRareNonInheritedData.cpp:
    (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
            
        Opportunistic fix. Don't know how to test.
    
    LayoutTests: 
    
    Reviewed by Andreas Kling.
            
    Unfortunately the automatic test provides code coverage only as reading back the properties
    from the style always gives back non-visited values. The bug is visible running the test
    manually.
    
    * transitions/visited-link-color-expected.txt: Added.
    * transitions/visited-link-color.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a40f8feb