Skip to content
  • mario.prada@samsung.com's avatar
    [ATK] AXChildrenChanged notification handling is a performance black hole · 2a7b84da
    mario.prada@samsung.com authored
    https://bugs.webkit.org/show_bug.cgi?id=126970
    
    Reviewed by Gustavo Noronha Silva.
    
    Source/WebCore:
    
    Remove code that is causing a huge performance problem when
    loading big pages, just to be able to emit the children-changed:add
    signal at the exact time a child is added.
    
    This removal does not imply that the signal won't be ever emitted,
    just that it will be emitted a bit later (when the new child is
    asynchronously added to the tree), which should be good enough
    anyway for Accessible Technologies, without impacting perfformance
    in such a negative way.
    
    * accessibility/atk/AXObjectCacheAtk.cpp:
    (WebCore::AXObjectCache::postPlatformNotification): Removed
    extremely expensive referring loop when AXChildrenChanged is received.
    
    LayoutTests:
    
    Because of the removal of the referring test when
    AXChildrenChanged is received, the children-changed:add signal is
    now emitted later, so we need to reorder the expectations.
    
    * accessibility/children-changed-sends-notification-expected.txt: Updated.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    2a7b84da