Skip to content
  • andersca@apple.com's avatar
    HostWindow invalidation functions should use root view coordinates · fdd25eb3
    andersca@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=72338
    
    Reviewed by Dan Bernstein.
    
    Source/WebCore:
    
    Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
    to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
    are in root view coordinates by changing contentsToWindow calls to contentsToRootView.
    
    In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
    and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.
    
    * loader/EmptyClients.h:
    * page/Chrome.cpp:
    (WebCore::Chrome::invalidateRootView):
    (WebCore::Chrome::invalidateContentsAndRootView):
    * page/Chrome.h:
    * page/ChromeClient.h:
    * page/Frame.cpp:
    (WebCore::Frame::tiledBackingStorePaintEnd):
    * page/FrameView.cpp:
    (WebCore::FrameView::invalidateRect):
    (WebCore::FrameView::scrollContentsFastPath):
    * platform/HostWindow.h:
    * platform/ScrollView.cpp:
    (WebCore::ScrollView::rectToCopyOnScroll):
    (WebCore::ScrollView::scrollContents):
    (WebCore::ScrollView::wheelEvent):
    * platform/chromium/FramelessScrollView.cpp:
    (WebCore::FramelessScrollView::invalidateRect):
    * svg/graphics/SVGImage.cpp:
    (WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
    
    Source/WebKit/chromium:
    
    * src/ChromeClientImpl.cpp:
    (WebKit::ChromeClientImpl::invalidateRootView):
    (WebKit::ChromeClientImpl::invalidateContentsAndRootView):
    (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):
    * src/ChromeClientImpl.h:
    * src/WebPopupMenuImpl.cpp:
    (WebKit::WebPopupMenuImpl::invalidateRootView):
    (WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
    (WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):
    * src/WebPopupMenuImpl.h:
    
    Source/WebKit/efl:
    
    * WebCoreSupport/ChromeClientEfl.cpp:
    (WebCore::ChromeClientEfl::invalidateRootView):
    (WebCore::ChromeClientEfl::invalidateContentsAndRootView):
    (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
    * WebCoreSupport/ChromeClientEfl.h:
    
    Source/WebKit/gtk:
    
    * WebCoreSupport/ChromeClientGtk.cpp:
    (WebKit::ChromeClient::invalidateRootView):
    (WebKit::ChromeClient::invalidateContentsAndRootView):
    (WebKit::ChromeClient::invalidateContentsForSlowScroll):
    * WebCoreSupport/ChromeClientGtk.h:
    
    Source/WebKit/mac:
    
    * WebCoreSupport/WebChromeClient.h:
    * WebCoreSupport/WebChromeClient.mm:
    (WebChromeClient::invalidateRootView):
    (WebChromeClient::invalidateContentsAndRootView):
    (WebChromeClient::invalidateContentsForSlowScroll):
    
    Source/WebKit/qt:
    
    * WebCoreSupport/ChromeClientQt.cpp:
    (WebCore::ChromeClientQt::invalidateRootView):
    (WebCore::ChromeClientQt::invalidateContentsAndRootView):
    (WebCore::ChromeClientQt::invalidateContentsForSlowScroll):
    * WebCoreSupport/ChromeClientQt.h:
    
    Source/WebKit/win:
    
    * WebCoreSupport/WebChromeClient.cpp:
    (WebChromeClient::invalidateRootView):
    (WebChromeClient::invalidateContentsAndRootView):
    * WebCoreSupport/WebChromeClient.h:
    
    Source/WebKit/wince:
    
    * WebCoreSupport/ChromeClientWinCE.cpp:
    (WebKit::ChromeClientWinCE::invalidateRootView):
    (WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
    (WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
    (WebKit::ChromeClientWinCE::scroll):
    * WebCoreSupport/ChromeClientWinCE.h:
    
    Source/WebKit/wx:
    
    * WebKitSupport/ChromeClientWx.cpp:
    (WebCore::ChromeClientWx::invalidateRootView):
    (WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
    (WebCore::ChromeClientWx::invalidateContentsAndRootView):
    * WebKitSupport/ChromeClientWx.h:
    
    Source/WebKit2:
    
    * WebProcess/WebCoreSupport/WebChromeClient.cpp:
    (WebKit::WebChromeClient::invalidateRootView):
    (WebKit::WebChromeClient::invalidateContentsAndRootView):
    * WebProcess/WebCoreSupport/WebChromeClient.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    fdd25eb3