Skip to content
  • commit-queue@webkit.org's avatar
    4809317e
    Spec renamed Viewport-relative lengths to Viewport-percentage lengths · 4809317e
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=82773
    
    Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-30
    Reviewed by Antti Koivisto.
    
    As per the latest version of CSS Values and Units Module Level 3 specification released on 29 March 2012
    (http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) Viewport-relative lengths is renamed to Viewport-percentage lengths.
    
    Source/WebCore:
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::getPositionOffsetValue):
    (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
    * css/CSSPrimitiveValue.cpp:
    (WebCore::unitCategory):
    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
    (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
    (WebCore::CSSPrimitiveValue::viewportPercentageLength):
    * css/CSSPrimitiveValue.h:
    (WebCore::CSSPrimitiveValue::isViewportPercentageLength):
    (CSSPrimitiveValue):
    * css/CSSPrimitiveValueMappings.h:
    (WebCore::CSSPrimitiveValue::convertToLength):
    * css/CSSStyleApplyProperty.cpp:
    (WebCore::ApplyPropertyLength::applyValue):
    (WebCore::ApplyPropertyBorderRadius::applyValue):
    (WebCore::ApplyPropertyFontSize::applyValue):
    (WebCore::ApplyPropertyLineHeight::applyValue):
    (WebCore::ApplyPropertyVerticalAlign::applyValue):
    * css/CSSStyleSelector.cpp:
    (WebCore::CSSStyleSelector::collectMatchingRulesForList):
    * css/LengthFunctions.cpp:
    (WebCore::minimumValueForLength):
    (WebCore::valueForLength):
    (WebCore::floatValueForLength):
    * platform/Length.h:
    (WebCore::Length::isViewportPercentage):
    (WebCore::Length::viewportPercentageLength):
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::textIndentOffset):
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::computeContentLogicalHeightUsing):
    (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
    * rendering/RenderBoxModelObject.cpp:
    (WebCore::RenderBoxModelObject::paddingTop):
    (WebCore::RenderBoxModelObject::paddingBottom):
    (WebCore::RenderBoxModelObject::paddingLeft):
    (WebCore::RenderBoxModelObject::paddingRight):
    (WebCore::RenderBoxModelObject::paddingBefore):
    (WebCore::RenderBoxModelObject::paddingAfter):
    (WebCore::RenderBoxModelObject::paddingStart):
    (WebCore::RenderBoxModelObject::paddingEnd):
    (WebCore::RenderBoxModelObject::calculateFillTileSize):
    * rendering/RenderInline.cpp:
    (WebCore::computeMargin):
    * rendering/style/RenderStyle.h:
    
    LayoutTests:
    
    * css3/viewport-percentage-lengths: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw.html: Added.
    * css3/viewport-relative-lengths: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    4809317e
    Spec renamed Viewport-relative lengths to Viewport-percentage lengths
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=82773
    
    Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-30
    Reviewed by Antti Koivisto.
    
    As per the latest version of CSS Values and Units Module Level 3 specification released on 29 March 2012
    (http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) Viewport-relative lengths is renamed to Viewport-percentage lengths.
    
    Source/WebCore:
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::getPositionOffsetValue):
    (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
    * css/CSSPrimitiveValue.cpp:
    (WebCore::unitCategory):
    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
    (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
    (WebCore::CSSPrimitiveValue::viewportPercentageLength):
    * css/CSSPrimitiveValue.h:
    (WebCore::CSSPrimitiveValue::isViewportPercentageLength):
    (CSSPrimitiveValue):
    * css/CSSPrimitiveValueMappings.h:
    (WebCore::CSSPrimitiveValue::convertToLength):
    * css/CSSStyleApplyProperty.cpp:
    (WebCore::ApplyPropertyLength::applyValue):
    (WebCore::ApplyPropertyBorderRadius::applyValue):
    (WebCore::ApplyPropertyFontSize::applyValue):
    (WebCore::ApplyPropertyLineHeight::applyValue):
    (WebCore::ApplyPropertyVerticalAlign::applyValue):
    * css/CSSStyleSelector.cpp:
    (WebCore::CSSStyleSelector::collectMatchingRulesForList):
    * css/LengthFunctions.cpp:
    (WebCore::minimumValueForLength):
    (WebCore::valueForLength):
    (WebCore::floatValueForLength):
    * platform/Length.h:
    (WebCore::Length::isViewportPercentage):
    (WebCore::Length::viewportPercentageLength):
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::textIndentOffset):
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::computeContentLogicalHeightUsing):
    (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
    * rendering/RenderBoxModelObject.cpp:
    (WebCore::RenderBoxModelObject::paddingTop):
    (WebCore::RenderBoxModelObject::paddingBottom):
    (WebCore::RenderBoxModelObject::paddingLeft):
    (WebCore::RenderBoxModelObject::paddingRight):
    (WebCore::RenderBoxModelObject::paddingBefore):
    (WebCore::RenderBoxModelObject::paddingAfter):
    (WebCore::RenderBoxModelObject::paddingStart):
    (WebCore::RenderBoxModelObject::paddingEnd):
    (WebCore::RenderBoxModelObject::calculateFillTileSize):
    * rendering/RenderInline.cpp:
    (WebCore::computeMargin):
    * rendering/style/RenderStyle.h:
    
    LayoutTests:
    
    * css3/viewport-percentage-lengths: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-expected.html: Added.
    * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw.html: Added.
    * css3/viewport-relative-lengths: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
    * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading