-
darin authored
- test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188) * fast/dom/Window/redirect-with-timer.html: Added. * fast/dom/Window/redirect-with-timer-expected.txt: Added. WebCore: Reviewed by Maciej. - fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188) Test: fast/dom/Window/redirect-with-timer.html * platform/Timer.h: Made isActive no longer inline. Added inHeap function. * platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
darin authored- test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188) * fast/dom/Window/redirect-with-timer.html: Added. * fast/dom/Window/redirect-with-timer-expected.txt: Added. WebCore: Reviewed by Maciej. - fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188) Test: fast/dom/Window/redirect-with-timer.html * platform/Timer.h: Made isActive no longer inline. Added inHeap function. * platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading