Skip to content
  • sullivan's avatar
    WebKit: · ec317767
    sullivan authored
    	- WebKit part of fix for 3028061 -- visiting a bookmarked site
    	that now has a site icon will not update bookmark's icon
    
    	No longer store the icon in the WebHistoryItem, since there's no
    	mechanism for keeping it fresh and telling interested clients
    	when it changes. Instead, the latest icon is always returned from
    	the icon database, and it's up to clients to get a fresh one when
    	they notice that the icon for a URL has been updated.
    
            Reviewed by Darin
    
            * History.subproj/WebHistoryItem.h:
    	remove _icon and _loadedIcon ivars
    
            * History.subproj/WebHistoryItem.m:
            (-[WebHistoryItem dealloc]):
    	don't release _icon
            (-[WebHistoryItem icon]):
    	just return fresh icon from database, don't store
            (-[WebHistoryItem setURL:]):
    	don't set _loadedIcon to NO
    
    WebBrowser:
    
    	- WebBrowser part of fix for 3028061 -- visiting a bookmarked site
    	that now has a site icon will not update bookmark's icon
    
    	This first cut, which fixes the bug completely, just tosses out
    	the cached bookmark & history menus & tells the outline view to
    	redisplay everything. We might improve this later, but in practice
    	the only difference in behavior that this will cause is to make
    	the Bookmarks menu rebuild itself from scratch when clicked on
    	more often. (We can address that multiple ways, probably the best
    	one being to make rebuilding much faster by using IconRefs instead
    	of NSImages, see 3120678.)
    
            Reviewed by Darin
    
            * BookmarksController.m:
            (-[BookmarksController awakeFromNib]):
    	register for icon-changed notifications
            (-[BookmarksController _receivedIconChangedNotification:]):
    	mark menu dirty when any icon has changed
    
            * BookmarksViewController.m:
            (-[BookmarksViewController awakeFromNib]):
    	register for icon-changed notifications
            (-[BookmarksViewController iconChanged:]):
    	reload outlineview data when any icon has changed. Note that this
    	has no effect when the outlineview is not showing.
    
            * GlobalHistory.m:
            (-[GlobalHistory _registerForHistoryNotifications]):
    	register for icon-changed notifications
            (-[GlobalHistory receivedIconChangedNotification:]):
    	mark menu dirty when any icon has changed
            (-[GlobalHistory receivedEntriesChangedNotification:]):
    	removed wayward space character
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ec317767