Skip to content
  • anilsson@rim.com's avatar
    [BlackBerry] SelectionHandler drops caret change notifications · eaf279e8
    anilsson@rim.com authored
    https://bugs.webkit.org/show_bug.cgi?id=96378
    
    Reviewed by Antonio Gomes.
    
    The selection handler deliberately drops caret change notifications
    while the input handler is processing changes, to avoid displaying
    intermediate state during a complex change.
    
    However, this meant that the client was never informed of the final
    caret position.
    
    Fixed by notifying client about caret change after processing ends, if
    one or more caret change notifications were dropped during processing.
    
    PR #205073
    
    Reviewed internally by Mike Fenton.
    
    * WebKitSupport/InputHandler.cpp:
    (BlackBerry::WebKit::InputHandler::setProcessingChange):
    (WebKit):
    * WebKitSupport/InputHandler.h:
    (InputHandler):
    * WebKitSupport/SelectionHandler.cpp:
    (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
    (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
    (WebKit):
    (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
    (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
    * WebKitSupport/SelectionHandler.h:
    (SelectionHandler):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    eaf279e8