Skip to content
  • leviw@chromium.org's avatar
    Switch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and... · e92ed537
    leviw@chromium.org authored
    Switch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocusRingRects back to integers
    https://bugs.webkit.org/show_bug.cgi?id=80545
    
    Reviewed by Simon Fraser.
    
    Converting the above functions, all of which return rects that represent on-screen rects, to IntRects from
    LayoutRects.
    
    addFocusRingsRects generates a vector of rects that is handed off directly to the GraphicsContext to be
    drawn. Snapping the rects before adding them to the vector saves an extra pass through the vector.
    
    absoluteRects and culledInlineAbsoluteRects are only used by addFocusRingRects, hasNonEmptyBoundingBox (only
    to check if they're empty), and absoluteBoundingBoxRect, which is exposed from WebCore and thus should be an
    IntRect anyways.
    
    No new tests. No change in behavior.
    
    * dom/Node.cpp:
    (WebCore::Node::hasNonEmptyBoundingBox):
    * dom/Range.cpp:
    (WebCore::Range::boundingBox):
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::absoluteRects):
    (WebCore::RenderBlock::addFocusRingRects):
    * rendering/RenderBlock.h:
    (RenderBlock):
    * rendering/RenderInline.cpp:
    (WebCore::RenderInline::absoluteRects):
    (WebCore::RenderInline::culledInlineAbsoluteRects):
    (WebCore::RenderInline::addFocusRingRects):
    * rendering/RenderInline.h:
    (RenderInline):
    * rendering/RenderListBox.cpp:
    (WebCore::RenderListBox::addFocusRingRects):
    * rendering/RenderListBox.h:
    (RenderListBox):
    * rendering/RenderObject.cpp:
    (WebCore::RenderObject::paintFocusRing):
    (WebCore::RenderObject::absoluteBoundingBoxRect):
    (WebCore::RenderObject::absoluteFocusRingQuads):
    * rendering/RenderObject.h:
    (WebCore::RenderObject::absoluteRects):
    (RenderObject):
    (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
    (WebCore::RenderObject::addFocusRingRects):
    * rendering/RenderText.cpp:
    (WebCore::RenderText::absoluteRects):
    (WebCore::RenderText::absoluteRectsForRange):
    * rendering/RenderText.h:
    (RenderText):
    * rendering/RenderTextControl.cpp:
    (WebCore::RenderTextControl::addFocusRingRects):
    * rendering/RenderTextControl.h:
    (RenderTextControl):
    * rendering/RenderView.cpp:
    (WebCore::RenderView::absoluteRects):
    * rendering/RenderView.h:
    (RenderView):
    * rendering/svg/RenderSVGBlock.cpp:
    (WebCore::RenderSVGBlock::absoluteRects):
    * rendering/svg/RenderSVGBlock.h:
    (RenderSVGBlock):
    * rendering/svg/RenderSVGContainer.cpp:
    (WebCore::RenderSVGContainer::addFocusRingRects):
    * rendering/svg/RenderSVGContainer.h:
    (RenderSVGContainer):
    * rendering/svg/RenderSVGImage.cpp:
    (WebCore::RenderSVGImage::addFocusRingRects):
    * rendering/svg/RenderSVGImage.h:
    (RenderSVGImage):
    * rendering/svg/RenderSVGModelObject.cpp:
    (WebCore::RenderSVGModelObject::absoluteRects):
    * rendering/svg/RenderSVGModelObject.h:
    (RenderSVGModelObject):
    * rendering/svg/RenderSVGShape.cpp:
    (WebCore::RenderSVGShape::addFocusRingRects):
    * rendering/svg/RenderSVGShape.h:
    (RenderSVGShape):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e92ed537