Skip to content
  • commit-queue@webkit.org's avatar
    Web Inspector: [DTE] Paint overlay highlight over line background color · e7437005
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=113346
    
    Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-28
    Reviewed by Pavel Feldman.
    
    Source/WebCore:
    
    No new tests: no change in behaviour.
    
    - Append spans instead of text nodes to lineRows.
    - Set positioning of all spans inside of webkit-line-content as
    relative
    - Set z-index property so that overlay highlight is above line
    background but under text.
    
    * inspector/front-end/DefaultTextEditor.js:
    (WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
    (WebInspector.TextEditorMainPanel.prototype._measureSpans):
    (WebInspector.TextEditorMainPanel.prototype._renderRanges):
    (WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
    * inspector/front-end/textEditor.css:
    (.webkit-line-content > .text-editor-overlay-highlight):
    (.webkit-line-content > *):
    
    LayoutTests:
    
    Updated test expectations to correspond to new DefaultTextEditor's DOM
    layout.
    
    * inspector/editor/text-editor-brace-highlighter-expected.txt:
    * inspector/editor/text-editor-highlight-api-expected.txt:
    * inspector/editor/text-editor-highlight-token-expected.txt:
    * inspector/editor/text-editor-long-line-expected.txt:
    * inspector/editor/text-editor-remove-chunks-from-dom-expected.txt:
    * inspector/editor/text-editor-show-whitespace-expected.txt:
    * inspector/editor/text-editor-type-over-decoration-expected.txt:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e7437005