Skip to content
  • paroga@webkit.org's avatar
    2011-05-12 Maciej Stachowiak <mjs@apple.com> · e729ed16
    paroga@webkit.org authored
            Reviewed by Darin Adler.
    
            XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
            https://bugs.webkit.org/show_bug.cgi?id=59394
    
            This portion of the change introduces a PassTraits template, which
            is used to enable takeFirst() to work for a Deque holding OwnPtrs,
            and optimize it for a Deque holding RefPtrs. In the future it can
            be deployed elsewhere to make our data structures work better with
            our smart pointers.
    
            * GNUmakefile.list.am:
            * JavaScriptCore.gypi:
            * JavaScriptCore.vcproj/WTF/WTF.vcproj:
            * JavaScriptCore.xcodeproj/project.pbxproj:
            * wtf/CMakeLists.txt:
            * wtf/Deque.h:
            (WTF::::takeFirst):
            * wtf/PassTraits.h: Added.
            (WTF::PassTraits::transfer):
    2011-05-12  Maciej Stachowiak  <mjs@apple.com>
    
            Reviewed by Darin Adler.
    
            XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
            https://bugs.webkit.org/show_bug.cgi?id=59394
    
            Properly fix this (formerly rolled out for breaking the build). I think the original
            failure had nothing to do with Deque<OwnPtr>, which in fact appears to work fine.
    
            * dom/XMLDocumentParserLibxml2.cpp:
            (WebCore::PendingCallbacks::~PendingCallbacks):
            (WebCore::PendingCallbacks::create):
            (WebCore::PendingCallbacks::appendStartElementNSCallback):
            (WebCore::PendingCallbacks::appendEndElementNSCallback):
            (WebCore::PendingCallbacks::appendCharactersCallback):
            (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
            (WebCore::PendingCallbacks::appendCDATABlockCallback):
            (WebCore::PendingCallbacks::appendCommentCallback):
            (WebCore::PendingCallbacks::appendInternalSubsetCallback):
            (WebCore::PendingCallbacks::appendErrorCallback):
            (WebCore::PendingCallbacks::PendingCallbacks):
            (WebCore::XMLDocumentParser::XMLDocumentParser):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e729ed16