Skip to content
  • commit-queue@webkit.org's avatar
    Web Inspector: Profiles: taking heap snapshot causes error message in console. · e508ef60
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=97890
    
    Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-03
    Reviewed by Yury Semikhatsky.
    
    Actual problem is that proxy loader is closed twice.
    
    "_snapshotReceived" should never try to close receiver,
    because it is a callback fired by close.
    
    Also minor glitches fixed:
     - taking snapshot shows "Loading..." status first,
    and then "Saving xxx%";
     - after all chunks are sent "Parsing" status is set and
    then is replaced with "Saving 100%";
     - removed dead code in proxy;
     - proxy was ignoring callback parameter;
     - "Loading %d\%" is not localized.
    
    * English.lproj/localizedStrings.js: Added missing "Loading %d%" string.
    * inspector/front-end/HeapSnapshotProxy.js: Removed dead code.
    (WebInspector.HeapSnapshotLoaderProxy):
    (WebInspector.HeapSnapshotLoaderProxy.prototype.write): Make this method
    interface-conformant.
    * inspector/front-end/HeapSnapshotView.js:
    (WebInspector.HeapProfileHeader): Fixed update-status and
    finish-transfer logic.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e508ef60