Skip to content
  • tommyw@google.com's avatar
    dd466b63
    MediaStream API: Extend UserMediaRequest with a ownerDocument method · dd466b63
    tommyw@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=97095
    
    Reviewed by Adam Barth.
    
    Source/WebCore:
    
    Chromium need to know exactly which frame called getUserMedia so that it can
    clean away the stream when the frame goes away.
    Since that information is available in webkit add an accessor method.
    
    Chromium mock class extended to test the added method.
    
    * Modules/mediastream/UserMediaRequest.cpp:
    (WebCore::UserMediaRequest::ownerDocument):
    (WebCore):
    * Modules/mediastream/UserMediaRequest.h:
    (WebCore):
    (UserMediaRequest):
    
    Source/WebKit/chromium:
    
    Chromium need to know exactly which frame called getUserMedia so that it can clean
    away the stream when the frame goes away.
    Since that information is available in webkit add an accessor method.
    
    Also taking the opportunity to remove an unused deprecated method,
    and adding asserts in case the object is empty.
    
    * public/WebUserMediaRequest.h:
    (WebKit):
    (WebUserMediaRequest):
    * src/WebUserMediaRequest.cpp:
    (WebKit::WebUserMediaRequest::ownerDocument):
    
    Tools:
    
    Extending WebUserMediaClientMock to check that the owning document is valid,
    and that the document has a frame.
    
    * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
    (WebKit::WebUserMediaClientMock::requestUserMedia):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    dd466b63
    MediaStream API: Extend UserMediaRequest with a ownerDocument method
    tommyw@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=97095
    
    Reviewed by Adam Barth.
    
    Source/WebCore:
    
    Chromium need to know exactly which frame called getUserMedia so that it can
    clean away the stream when the frame goes away.
    Since that information is available in webkit add an accessor method.
    
    Chromium mock class extended to test the added method.
    
    * Modules/mediastream/UserMediaRequest.cpp:
    (WebCore::UserMediaRequest::ownerDocument):
    (WebCore):
    * Modules/mediastream/UserMediaRequest.h:
    (WebCore):
    (UserMediaRequest):
    
    Source/WebKit/chromium:
    
    Chromium need to know exactly which frame called getUserMedia so that it can clean
    away the stream when the frame goes away.
    Since that information is available in webkit add an accessor method.
    
    Also taking the opportunity to remove an unused deprecated method,
    and adding asserts in case the object is empty.
    
    * public/WebUserMediaRequest.h:
    (WebKit):
    (WebUserMediaRequest):
    * src/WebUserMediaRequest.cpp:
    (WebKit::WebUserMediaRequest::ownerDocument):
    
    Tools:
    
    Extending WebUserMediaClientMock to check that the owning document is valid,
    and that the document has a frame.
    
    * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
    (WebKit::WebUserMediaClientMock::requestUserMedia):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading