Skip to content
  • arv@chromium.org's avatar
    2009-11-23 Erik Arvidsson <arv@chromium.org> · dcecd918
    arv@chromium.org authored
            Reviewed by Eric Seidel.
    
            JSC bindings for HasIndexGetter generates incorrect code (affects
            MediaList and CSSStyleDeclaration).
            This cleans up the edge cases for indexing out of range for style and
            computed style objects to return an empty string according to the spec.
            MediaList now returns null when indexed out of range.
            https://bugs.webkit.org/show_bug.cgi?id=31683
    
            * fast/dom/CSSStyleDeclaration/css-computed-style-item-expected.txt: Added.
            * fast/dom/CSSStyleDeclaration/css-computed-style-item.html: Added.
            * fast/dom/CSSStyleDeclaration/css-style-item-expected.txt: Added.
            * fast/dom/CSSStyleDeclaration/css-style-item.html: Added.
            * fast/dom/CSSStyleDeclaration/script-tests/css-computed-style-item.js: Added.
            * fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js: Added.
            * fast/dom/StyleSheet/css-medialist-item-expected.txt: Added.
            * fast/dom/StyleSheet/css-medialist-item.html: Added.
            * fast/dom/StyleSheet/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
            * fast/dom/StyleSheet/script-tests/css-medialist-item.js: Added.
    2009-11-23  Erik Arvidsson  <arv@chromium.org>
    
            Reviewed by Eric Seidel.
    
            JSC bindings for HasIndexGetter generates incorrect code (affects
            MediaList and CSSStyleDeclaration).
            This cleans up the edge cases for indexing out of range for style and
            computed style objects to return an empty string according to the spec.
            MediaList now returns null when indexed out of range.
            https://bugs.webkit.org/show_bug.cgi?id=31683
    
            Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html
                   fast/dom/CSSStyleDeclaration/css-style-item.html
                   fast/dom/StyleSheet/css-medialist-item.html
    
            * bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then
                    we do not check the length before calling the item function.
            * css/CSSComputedStyleDeclaration.cpp:
            (WebCore::CSSComputedStyleDeclaration::item):
            * css/CSSMutableStyleDeclaration.cpp:
            (WebCore::CSSMutableStyleDeclaration::item):
            * css/CSSStyleDeclaration.idl:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    dcecd918