Skip to content
  • mario@webkit.org's avatar
    [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries · dc76999d
    mario@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=114872
    
    Reviewed by Gustavo Noronha Silva.
    
    Source/WebCore:
    
    Re-implement these functions without using GailTextUtil nor Pango.
    
    * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
    (lineAtPositionForAtkBoundary): New helper function to find the
    line at a given position considering values of AtkTextBoundary.
    (webkitAccessibleTextLineForBoundary): New function,
    implementing atk_text_get_text_*_offset for LINE.
    (webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
    LINE boundaries with webkitAccessibleTextLineForBoundary().
    
    Source/WebKit/gtk:
    
    Fixed wrong unit test.
    
    * tests/testatk.c:
    (testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
    reporting a trailing '\n' for some reason for a <pre> block, which
    is plainly wrong since, in order to return that, there should be
    at least a trailing empty space after that and before the </pre>
    closing tag. This is fixed now.
    (testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
    that were previously not passing due to a bug in GailTextUtil.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    dc76999d