-
tsepez@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=93283 Reviewed by Eric Seidel. Source/WebCore: Chromium has a refptr that needs to be NULLed at this point. The approach is to change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, and the use this to clear the refptr on the chromium platform. Other platforms can merely ignore the NULL case, thereby maintaining the existing behaviour. Formal testing is nearly impossible without some chrome-specific plugins. * html/PluginDocument.cpp: (WebCore::PluginDocument::detach): Source/WebKit/blackberry: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebCoreSupport/FrameLoaderClientBlackBerry.cpp: (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin): Source/WebKit/chromium: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, NULLing Chromium's refptr that needs to be NULLed. * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::redirectDataToPlugin): Source/WebKit/efl: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::redirectDataToPlugin): Source/WebKit/gtk: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::redirectDataToPlugin): Source/WebKit/qt: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::redirectDataToPlugin): Source/WebKit/win: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::redirectDataToPlugin): Source/WebKit/wince: Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::redirectDataToPlugin): Source/WebKit/wx: Chromium has a refptr that needs to be NULLed at this point. Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::redirectDataToPlugin): Source/WebKit2: Chromium has a refptr that needs to be NULLed at this point. Change the client redirectDataToPlugin method(s) to expect the possibility of a NULL argument, keeping existing behaviour otherwise. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::redirectDataToPlugin): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
dc44a128