Skip to content
  • cfleizach@apple.com's avatar
    WebCore: Bug 28200 - ListMarker should be included as part of the text value to parse · d82fd890
    cfleizach@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=28200
    
    Reviewed by Darin Adler.
    
    When returning text through the marker range attributes, the list marker text should
    also be included. It isn't included by default because a TextIterator is used which
    only looks at Nodes for text. A list marker does not have a corresponding node,
    so its text is not returned through accessibility. That is, until now.
    
    Test: platform/mac/accessibility/string-range-contains-listmarker.html
    
    * accessibility/AccessibilityObject.cpp:
    (WebCore::AccessibilityObject::listMarkerTextForRange):
    (WebCore::AccessibilityObject::stringForVisiblePositionRange):
    * accessibility/AccessibilityObject.h:
    * accessibility/mac/AccessibilityObjectWrapper.mm:
    (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
    (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
    (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
    * rendering/RenderListItem.h:
    
    Make markerText() public so that accessibility code can access it.
    
    WebKitTools: Bug 28200 - ListMarker should be included as part of the text value to parse
    https://bugs.webkit.org/show_bug.cgi?id=28200
    
    Reviewed by Darin Adler.
    
    Add the ability to retrieve a string given a plain NSRange.
    
    * DumpRenderTree/AccessibilityUIElement.cpp:
    (stringForRangeCallback):
    (AccessibilityUIElement::getJSClass):
    * DumpRenderTree/AccessibilityUIElement.h:
    * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
    (AccessibilityUIElement::valueDescription):
    (AccessibilityUIElement::stringForRange):
    * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
    (AccessibilityUIElement::stringForRange):
    
    LayoutTests: Bug 28200 - ListMarker should be included as part of the text value to parse
    https://bugs.webkit.org/show_bug.cgi?id=28200
    
    Reviewed by Darin Adler.
    
    Tests for checking that the list marker text is included when asking for text 
    through accessibility.
    
    * platform/mac/accessibility/bounds-for-range-expected.txt.
    * platform/mac/accessibility/string-range-contains-listmarker-expected.txt: Added.
    * platform/mac/accessibility/string-range-contains-listmarker.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d82fd890