Skip to content
  • jparent@chromium.org's avatar
    Dashboard refactor: Move cross dashboard history related code into history.js. · d7e6518c
    jparent@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=113104
    
    Reviewed by Ojan Vafai.
    
    All functions relating to cross dashboard behavior move from being
    globals to methods on the history.History object. Names stay the same,
    except many are made private, ones that should have been constants now
    are, and the long standing TODO to change "currentState" to
    dashboardSpecificState is done.
    
    We now create a global history object in dashboard_base, as an
    intermediate measure.  Once the dashboard specific code is
    added to history, each DB will need to create its own, and this
    global will be eliminated.
    
    * TestResultServer/static-dashboards/aggregate_results.js:
    (handleValidHashParameter):
    (htmlForBuilder):
    (rawValuesHTML):
    * TestResultServer/static-dashboards/dashboard_base.js:
    (parseDashboardSpecificParameters):
    (defaultValue):
    (currentBuilderGroupCategory):
    (currentBuilderGroupName):
    (handleLocationChange):
    (expectationsMap):
    * TestResultServer/static-dashboards/flakiness_dashboard.js:
    (generatePage):
    (.switch.return):
    (platformAndBuildType):
    (individualTests):
    (substringList):
    (processMissingAndExtraExpectations):
    (pathToFailureLog):
    (showPopupForBuild):
    (htmlForTestsWithExpectationsButNoFailures):
    (shouldHideTest):
    (isCrossBuilderView):
    (tableHeaders):
    (htmlForSingleTestRow):
    (htmlForTableColumnHeader):
    (generatePageForExpectationsUpdate):
    (handleUpdate):
    (nextUpdate):
    (setUpdateIndex):
    (htmlForIndividualTestOnAllBuildersWithResultsLinks):
    (.appendExpectationsItem):
    (loadExpectations):
    (.dummyNode.onload):
    (loadExpectationsLayoutTests):
    (appendExpectations):
    (htmlForNavBar):
    (checkBoxToToggleState):
    (linkHTMLToToggleState):
    (generatePageForBuilder):
    (isInvalidKeyForCrossBuilderView):
    (handleQueryParameterChange):
    (showLegend):
    * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
    (resetGlobals):
    (test):
    * TestResultServer/static-dashboards/history.js:
    (.):
    * TestResultServer/static-dashboards/history_unittests.js:
    * TestResultServer/static-dashboards/loader.js:
    (.):
    * TestResultServer/static-dashboards/loader_unittests.js:
    * TestResultServer/static-dashboards/timeline_explorer.js:
    (generatePage):
    (initCurrentBuilderTestResults):
    (selectBuild):
    (showResultsDelta):
    * TestResultServer/static-dashboards/treemap.js:
    (generatePage):
    (.switch.return):
    (handleFocus):
    * TestResultServer/static-dashboards/ui.js:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d7e6518c