Skip to content
  • justing's avatar
    d745df2e
    LayoutTests: · d745df2e
    justing authored
            Reviewed by levi
    
            Added, test for the crash by focusing an editable html element and then
            inserting a tab
            * editing/selection/editable-html-element-expected.checksum: Added.
            * editing/selection/editable-html-element-expected.png: Added.
            * editing/selection/editable-html-element-expected.txt: Added.
            * editing/selection/editable-html-element.html: Added.
            Fixed:
            * editing/selection/focus_editable_html-expected.checksum:
            * editing/selection/focus_editable_html-expected.png:
            * editing/selection/focus_editable_html-expected.txt:
    
    WebCore:
    
            Reviewed by levi
            
            <rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message
    
            * dom/Position.cpp:
            (WebCore::Position::inRenderedContent):
            Removed a candidate at [html, 0].
            * editing/CreateLinkCommand.cpp:
            (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
            * editing/InsertLineBreakCommand.cpp:
            (WebCore::InsertLineBreakCommand::doApply): Ditto.
            * editing/InsertTextCommand.cpp:
            (WebCore::InsertTextCommand::input): Ditto.
            * editing/Selection.cpp:
            (WebCore::Selection::validate): If visible positions can't be created from the endpoints, 
            then create a null selection.  Not doing this was making editing code think there was
            a valid, editable selection even though there wasn't.
            * editing/UnlinkCommand.cpp:
            (WebCore::UnlinkCommand::doApply): Early return.
            * editing/VisiblePosition.cpp:
            (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary.
            It looks like a non-editable/editable boundary since rootEditableElement stops at the body
            even if the html element is editable.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d745df2e
    LayoutTests:
    justing authored
            Reviewed by levi
    
            Added, test for the crash by focusing an editable html element and then
            inserting a tab
            * editing/selection/editable-html-element-expected.checksum: Added.
            * editing/selection/editable-html-element-expected.png: Added.
            * editing/selection/editable-html-element-expected.txt: Added.
            * editing/selection/editable-html-element.html: Added.
            Fixed:
            * editing/selection/focus_editable_html-expected.checksum:
            * editing/selection/focus_editable_html-expected.png:
            * editing/selection/focus_editable_html-expected.txt:
    
    WebCore:
    
            Reviewed by levi
            
            <rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message
    
            * dom/Position.cpp:
            (WebCore::Position::inRenderedContent):
            Removed a candidate at [html, 0].
            * editing/CreateLinkCommand.cpp:
            (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
            * editing/InsertLineBreakCommand.cpp:
            (WebCore::InsertLineBreakCommand::doApply): Ditto.
            * editing/InsertTextCommand.cpp:
            (WebCore::InsertTextCommand::input): Ditto.
            * editing/Selection.cpp:
            (WebCore::Selection::validate): If visible positions can't be created from the endpoints, 
            then create a null selection.  Not doing this was making editing code think there was
            a valid, editable selection even though there wasn't.
            * editing/UnlinkCommand.cpp:
            (WebCore::UnlinkCommand::doApply): Early return.
            * editing/VisiblePosition.cpp:
            (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary.
            It looks like a non-editable/editable boundary since rootEditableElement stops at the body
            even if the html element is editable.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading