Skip to content
  • jsbell@chromium.org's avatar
    IndexedDB: Remove IDBVersionChangeRequest · d57bce8b
    jsbell@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=107711
    
    Reviewed by Tony Chang.
    
    Source/WebCore:
    
    When the setVersion() API was removed from the Indexed DB spec the IDBVersionChangeRequest
    interface was replaced with IDBOpenDBRequest. We switched over for open(), this completes
    the work by switching over for deleteDatabase() and removing the old code. (On the Event
    side we still need to combine IDBVersionChangeEvent and IDBUpgradeNeededEvent.)
    
    Test: storage/indexeddb/intversion-long-queue.html
          storage/indexeddb/intversion-upgrades.html
    
    * CMakeLists.txt: Remove references to deleted code.
    * DerivedSources.make: Ditto.
    * GNUmakefile.list.am: Ditto.
    * Modules/indexeddb/IDBCallbacks.h: Remove unused onBlocked() overload.
    * Modules/indexeddb/IDBDatabase.cpp: Remove references to deleted code.
    * Modules/indexeddb/IDBDatabase.h: Ditto.
    * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
    (WebCore::IDBDatabaseBackendImpl::deleteDatabase): Fire onBlocked with current version.
    * Modules/indexeddb/IDBFactory.cpp:
    (WebCore::IDBFactory::openInternal): Don't need to specify source.
    (WebCore::IDBFactory::deleteDatabase): Use an IDBOpenDBRequest.
    * Modules/indexeddb/IDBFactory.h: Change return type of deleteDatabase()
    * Modules/indexeddb/IDBFactory.idl: Ditto.
    * Modules/indexeddb/IDBOpenDBRequest.cpp:
    (WebCore::IDBOpenDBRequest::create): Always use a null source.
    (WebCore::IDBOpenDBRequest::IDBOpenDBRequest): Pass null source to base class.
    (WebCore::IDBOpenDBRequest::dispatchEvent): Don't assume result is a database in existing
    special case.
    * Modules/indexeddb/IDBOpenDBRequest.h: Don't need a source argument (always null).
    * Modules/indexeddb/IDBVersionChangeRequest.cpp: Removed.
    * Modules/indexeddb/IDBVersionChangeRequest.h: Removed.
    * Modules/indexeddb/IDBVersionChangeRequest.idl: Removed.
    * WebCore.gypi: Remove references to deleted code.
    * WebCore.xcodeproj/project.pbxproj: Remove references to deleted code.
    * dom/EventTarget.h: Remove references to deleted code.
    * dom/EventTargetFactory.in: Ditto.
    
    Source/WebKit/chromium:
    
    * public/WebIDBCallbacks.h: Note to delete onBlocked() once Chromium is cleaned up.
    * src/IDBCallbacksProxy.cpp: Remove unused onBlocked() overload.
    * src/IDBCallbacksProxy.h: Ditto.
    * src/WebIDBCallbacksImpl.cpp: Ditto.
    * src/WebIDBCallbacksImpl.h: Ditto.
    * tests/IDBAbortOnCorruptTest.cpp: Ditto.
    * tests/IDBDatabaseBackendTest.cpp: Ditto.
    
    LayoutTests:
    
    Update expectations - change a handful of FAIL to PASS because past-us were awesome.
    
    * storage/indexeddb/intversion-long-queue-expected.txt:
    * storage/indexeddb/intversion-upgrades-expected.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d57bce8b