Skip to content
  • darin@apple.com's avatar
    WebCore: · c9bc8d37
    darin@apple.com authored
            Reviewed by Sam.
    
            - fix http://bugs.webkit.org/show_bug.cgi?id=16770
              Acid3 expects :visited styled links to restyle on iframe load
    
            Disentangle global history updating from the back/forward history.
            There are many cases where we don't want to create a new back/forward
            item, but we do still want to add to the global history (used for visited
            link coloring) in those cases.
    
            Test: fast/history/subframe-is-visited.html
    
            * loader/FrameLoader.cpp:
            (WebCore::FrameLoader::updateGlobalHistory): Renamed from
            addHistoryForCurrentLocation and removed the back/forward handling.
            (WebCore::FrameLoader::updateHistoryForStandardLoad): Streamlined logic a
            bit. Replaced call to addHistoryForCurrentLocation with a call to
            addBackForwardItemClippedAtTarget. Added an unconditional call to
            updateGlobalHistory.
            (WebCore::FrameLoader::updateHistoryForClientRedirect): Added a FIXME;
            why doesn't this function update global history?
            (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Ditto.
            (WebCore::FrameLoader::updateHistoryForReload): Replaced the direct call
            the client with a call to the new updateGlobalHistory function.
            (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Did
            the same changes as for updateHistoryForStandardLoad.
            * loader/FrameLoader.h: More of the same.
    
            * loader/FrameLoaderClient.h: Removed updateGlobalHistoryForReload and
            renamed updateGlobalHistoryForStandardLoad to updateGlobalHistory.
    
            * svg/graphics/SVGImageEmptyClients.h:
            (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistory): Updated to
            match the above.
    
    WebKit/gtk:
    
            Reviewed by Sam.
    
            - remove separate client calls for "standard" and "reload' history
    
            * WebCoreSupport/FrameLoaderClientGtk.cpp:
            (WebKit::FrameLoaderClient::updateGlobalHistory):
            * WebCoreSupport/FrameLoaderClientGtk.h:
    
    WebKit/mac:
    
            Reviewed by Sam.
    
            - remove separate client calls for "standard" and "reload' history
    
            * WebCoreSupport/WebFrameLoaderClient.h:
            * WebCoreSupport/WebFrameLoaderClient.mm:
            (WebFrameLoaderClient::updateGlobalHistory):
    
    WebKit/qt:
    
            Reviewed by Sam.
    
            - remove separate client calls for "standard" and "reload' history
    
            * WebCoreSupport/FrameLoaderClientQt.cpp:
            (WebCore::FrameLoaderClientQt::updateGlobalHistory):
            * WebCoreSupport/FrameLoaderClientQt.h:
    
    WebKit/win:
    
            Reviewed by Sam.
    
            - remove separate client calls for "standard" and "reload' history
    
            * WebFrame.cpp:
            (WebFrame::updateGlobalHistory):
            * WebFrame.h:
    
    WebKit/wx:
    
            Reviewed by Sam.
    
            - remove separate client calls for "standard" and "reload' history
    
            * WebKitSupport/FrameLoaderClientWx.cpp:
            (WebCore::FrameLoaderClientWx::updateGlobalHistory):
            * WebKitSupport/FrameLoaderClientWx.h:
    
    LayoutTests:
    
            Reviewed by Sam.
    
            - test for http://bugs.webkit.org/show_bug.cgi?id=16770
              Acid3 expects :visited styled links to restyle on iframe load
    
            * fast/history/resources/subframe.html: Added.
            * fast/history/subframe-is-visited-expected.txt: Added.
            * fast/history/subframe-is-visited.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c9bc8d37