Skip to content
  • darin's avatar
    WebCore: · c7a89cb8
    darin authored
    	- fixed 3069264 -- REGRESSION: windows created for links with
    	target=blank start out hidden (window menu only)
    
            * kwq/WebCoreBridge.h: Removed openNewWindowWithURL:referrer:frameName: and
    	added createWindowWithURL:referrer:frameName: and showWindow.
    
            * kwq/KWQKHTMLPartBrowserExtension.mm:
            (KHTMLPartBrowserExtension::createNewWindow): Call createWindowWithURL,
    	and then showWindow after the window is set up. Also change the code that
    	flips coordinates to always use the height of the first screen instead of
    	using the height of the screen the window is on, which sounds right, but
    	is wrong.
    
            * kwq/KWQKHTMLPartImpl.mm:
            (KWQKHTMLPartImpl::bridgeForFrameName): Call createWindowWithURL and then
    	showWindow in the case where we create a window.
            (KWQKHTMLPartImpl::urlSelected): Remove unused command-click code. The real
    	command-click code is in the browser now.
    
    WebKit:
    
    	WebKit support for creating windows and then showing them later
    	after setting them up.
    
            * WebCoreSupport.subproj/WebBridge.m:
            (-[WebBridge createWindowWithURL:referrer:frameName:]): Replaced the old
    	openNewWindowWithURL with this. It calls the new window operations delegate
    	method.
            (-[WebBridge showWindow]): Added. Calls the window operations delegate showWindow method.
            (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
    	Call _createFrameNamed instead of createFrameNamed.
    
            * WebView.subproj/WebWindowOperationsDelegate.h: Replaced the openNewWindowWithURL
    	method with a new method named createWindowWithURL. Added showWindow and showWindowBehindFrontmost.
    
            * WebView.subproj/WebControllerPrivate.h: Renamed createFrameNamed to _createFrameNamed
    	and removed the data source parameter. Added _openNewWindowWithURL:referrer:behind:
    	for the convenience of those who used to call the window operations delegate directly
    	to open the window.
            * WebView.subproj/WebControllerPrivate.m:
            (-[WebController _createFrameNamed:inParent:allowsScrolling:]): Renamed, and removed
    	the data source parameter.
            (-[WebController _openNewWindowWithURL:referrer:behind:]): Added.
    
            * Plugins.subproj/WebBaseNetscapePluginView.m:
            (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
            * WebView.subproj/WebDefaultContextMenuDelegate.m:
            (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]):
            * WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]):
            * WebView.subproj/WebHTMLViewPrivate.m:
            (-[WebHTMLView _continueAfterClickPolicyForEvent:]):
    	Use a private WebController method instead of calling the delegate directly,
    	because it now takes two method calls to create and display a new window.
    
            * Misc.subproj/WebNSViewExtras.m:
            * WebCoreSupport.subproj/WebSubresourceClient.m:
            * WebView.subproj/WebController.m:
            * WebView.subproj/WebDataSource.m:
            * WebView.subproj/WebFramePrivate.m:
            * WebView.subproj/WebHTMLView.m:
            * WebView.subproj/WebMainResourceClient.m:
            * WebView.subproj/WebPreferences.m:
            * WebView.subproj/WebView.m:
            * WebView.subproj/WebViewPrivate.m:
    	Tweaked comments.
    
    WebBrowser:
    
    	WebBrowser support for creating windows and then showing them later
    	after setting them up.
    
            * BrowserDocumentController.h: Add a new policy, CreateHiddenWindow.
            * BrowserDocumentController.m:
            (-[BrowserDocumentController _goToEachURL:referrer:windowPolicy:]):
    	Pass NO for display if policy is CreateHiddenWindow.
            (-[BrowserDocumentController tryMultipleURLs:windowPolicy:]): Ditto.
    
            * BrowserWebController.m:
            (-[BrowserWebController createWindowWithURL:referrer:]): Added. Like
    	the old openNewWindowWithURL method, but uses CreateHiddenWindow.
            (-[BrowserWebController showWindow]): Added. Tells the window controller
    	to show the window.
            (-[BrowserWebController showWindowBehindFrontmost]): Added. Tells the
    	window controllers to show the window after telling the document that
    	the window should open behind the frontmost.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c7a89cb8