Skip to content
  • beidson@apple.com's avatar
    Small ResourceLoader cleanups. · c289a14d
    beidson@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=112279
    
    Reviewed by Geoff Garen.
    
    Source/WebCore:
    
    No new tests (Refactor with no behavior change).
    
    1 - Add "OVERRIDE" to virtual methods in subclasses of ResourceLoader to catch future mistakes.
    2 - Replace the "bool allAtOnce" flag with a descriptive enum to make reading code easier.
    
    * GNUmakefile.list.am:
    * Target.pri:
    * WebCore.gypi:
    * WebCore.vcproj/WebCore.vcproj:
    * WebCore.xcodeproj/project.pbxproj:
    
    * loader/DocumentLoader.cpp:
    (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
    
    * loader/NetscapePlugInStreamLoader.cpp:
    (WebCore::NetscapePlugInStreamLoader::didReceiveData):
    * loader/NetscapePlugInStreamLoader.h:
    
    * loader/ResourceLoader.cpp:
    (WebCore::ResourceLoader::addData):
    (WebCore::ResourceLoader::didReceiveData):
    * loader/ResourceLoader.h:
    * loader/ResourceLoaderTypes.h: Added.
    
    * loader/SubresourceLoader.cpp:
    (WebCore::SubresourceLoader::didReceiveData):
    * loader/SubresourceLoader.h:
    
    Source/WebKit2:
    
    Replace the "bool allAtOnce" flag with a descriptive enum to make reading code easier.
    
    * NetworkProcess/NetworkResourceLoader.cpp:
    (WebKit::NetworkResourceLoader::didReceiveData):
    
    * WebProcess/Network/WebResourceLoader.cpp:
    (WebKit::WebResourceLoader::didReceiveData):
    (WebKit::WebResourceLoader::didReceiveResource):
    * WebProcess/Network/WebResourceLoader.h:
    * WebProcess/Network/WebResourceLoader.messages.in: Get rid of the "allAtOnce" flag since it was always false.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c289a14d