Skip to content
  • darin's avatar
    WebCore: · c26ab578
    darin authored
    	- fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs
    
    	Some places here did KURL::decode_string, but others didn't.
    
            * khtml/khtml_part.cpp:
            (KHTMLPart::slotShowDocument): Added call to KURL::decode_string.
            (KHTMLPart::overURL): Ditto.
            (KHTMLPart::urlSelected): Ditto.
            (KHTMLPart::requestFrame): Ditto.
            (KHTMLPart::slotChildURLRequest): Ditto.
    
    WebKit:
    
    	- improved the code that manages observing the window and superview
    
            * WebView.subproj/WebHTMLView.m:
            (-[WebHTMLView addSuperviewObservers]): Added.
            (-[WebHTMLView removeSuperviewObservers]): Added.
            (-[WebHTMLView addWindowObservers]): Added.
            (-[WebHTMLView removeWindowObservers]): Added.
            (-[WebHTMLView viewWillMoveToSuperview:]): Call removeSuperviewObservers.
            (-[WebHTMLView viewDidMoveToSuperview]): Call addSuperviewObservers.
            (-[WebHTMLView viewWillMoveToWindow:]): Call removeWindowObservers and
    	removeSuperviewObservers.
            (-[WebHTMLView viewDidMoveToWindow]): Call addWindowObservers and
    	addSuperviewObservers.
    
    WebBrowser:
    
    	- fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs
    
            * BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
    	Call CFURLCreateStringByReplacingPercentEscapes on the URL fragment before
    	passing it to stringByEvaluatingJavaScriptFromString:.
            * BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]):
    	Ditto.
    
    	- fixed world leaks seen when playing with the snippet window
    
            * Debug/SnippetController.m:
            (-[SnippetController dealloc]): Release the location change delegate to avoid a leak.
    	Also release the data source now that we retain it.
            (-[SnippetController windowWillClose:]): Release everything here. If we don't we get
    	a world leak. Also remove the WebView from the superview. If we don't, it leaks.
    	At some point we should look into this because it may indicate a WebKit problem, so
    	I marked it with a FIXME.
            (-[SnippetController load]): Retain the data source.
            (-[SnippetController loadComplete]): Release the old text storage.
    
            * Debug/SnippetController.h: Tweaks.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c26ab578