• sullivan's avatar
    WebKit: · bf53f40f
    sullivan authored
    	- to help with performance of various bookmark operations,
    	added a call that returns the internal array of children,
    	to complement the safer call that returns a copy.
    
            Reviewed by Darin
    
            * Bookmarks.subproj/WebBookmark.h:
    	commented -children and new -rawChildren
            * Bookmarks.subproj/WebBookmark.m:
            (-[WebBookmark rawChildren]):
    	new method, returns nil at this level.
            (-[WebBookmark contentMatches:]):
    	use -rawChildren instead of -children
    
            * Bookmarks.subproj/WebBookmarkList.m:
            (-[WebBookmarkList rawChildren]):
    	new method, returns internal array without copying
    
    WebBrowser:
    
    	- fixed 3129823 -- displaying many bookmarks in outline view is very slow
    
    	Deployed new rawChildren call everywhere appropriate in WebBrowser. This
    	prevents a lot of array-creation. On my machine, the time it takes to
    	display a folder containing 1000 items went from 0.96 sec to 0.0084 sec.
    
            Reviewed by Darin
    
            * BookmarksController.m:
            (-[BookmarksController addChildrenOfBookmark:toMenu:]):
            (-[BookmarksController goToNthFavoriteLeaf:]):
            (-[BookmarksController _addBookmarksToMenu]):
            (-[BookmarksController mergeBookmarksFrom:to:]):
            (-[BookmarksController mergeBuiltInBookmarksIfNecessary]):
            (-[BookmarksController importInternetExplorerFavorites]):
            (-[BookmarksController updateBookmarkSources]):
            (-[BookmarksController favoriteBookmarks]):
            (-[BookmarksController addFavoriteBookmark:atIndex:]):
            (-[BookmarksController recursivelyAddChildFoldersOf:toMenu:withIndentationLevel:]):
    	use -rawChildren instead of -children
    
            * BookmarksViewController.m:
            (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]):
    	use -rawChildren instead of -children
            (-[BookmarksViewController bookmarkSources]):
    	use -rawChildren instead of -children
            (-[BookmarksViewController refreshContents]):
    	log timing
            (-[BookmarksViewController canRemoveBookmarkSource:]):
    	use -rawChildren instead of -children
            (-[BookmarksViewController deleteSelectedContentItems]):
    	log timing
            (-[BookmarksViewController child:ofContentItem:usingSource:]):
    	use -rawChildren instead of -children
            (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
    	use -rawChildren instead of -children
            (-[BookmarksViewController paste:]):
    	log timing; use -rawChildren instead of -children
            (-[BookmarksViewController initWithBookmark:bookmark:]):
    	use -rawChildren instead of -children
    
            (+[CompletionController _addBookmarkTree:]):
    	use -rawChildren instead of -children
            (+[CompletionController _removeBookmarkTree:]):
    	use -rawChildren instead of -children
    
            * FavoriteButton.m:
            (-[FavoriteButton _contentsMenu]):
    	use -rawChildren instead of -children
    
            * WebBrowser.pbproj/project.pbxproj: version wars
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    bf53f40f