• commit-queue@webkit.org's avatar
    2011-02-19 Charlie Reis <creis@chromium.org> · bdaa062c
    commit-queue@webkit.org authored
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Tests that going forward within the same document does not stop loading.
    
            * http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
            * http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
            * http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Avoid stopping all loaders in goToItem for same document navigations
            or pseudo-back-forward URLs.  Make HistoryController::goToItem private
            to force callers to go through Page::goToItem.  Also add a callback to
            FrameLoaderClient to let clients decide whether to stop loading first.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * loader/EmptyClients.h:
            * loader/FrameLoader.h:
            * loader/FrameLoaderClient.h:
            * loader/HistoryController.cpp:
            * loader/HistoryController.h:
            * page/Page.cpp:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Call Page::goToItem instead of HistoryController::goToItem, so that
            FrameLoader::stopAllLoaders is called first.  Also adds a callback in
            FrameLoaderClient for checking for pseudo-back-forward URLs.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * src/FrameLoaderClientImpl.cpp:
            (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
            * src/FrameLoaderClientImpl.h:
            * src/WebFrameImpl.cpp:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/FrameLoaderClientEfl.cpp:
            (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/FrameLoaderClientEfl.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/FrameLoaderClientGtk.cpp:
            (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/FrameLoaderClientGtk.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/FrameLoaderClientHaiku.cpp:
            (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/FrameLoaderClientHaiku.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/WebFrameLoaderClient.mm:
            (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/WebFrameLoaderClient.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/FrameLoaderClientQt.cpp:
            (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/FrameLoaderClientQt.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/WebFrameLoaderClient.cpp:
            (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/WebFrameLoaderClient.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebCoreSupport/FrameLoaderClientWinCE.cpp:
            (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
            * WebCoreSupport/FrameLoaderClientWinCE.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebKitSupport/FrameLoaderClientWx.cpp:
            (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
            * WebKitSupport/FrameLoaderClientWx.h:
    2011-02-19  Charlie Reis  <creis@chromium.org>
    
            Reviewed by Mihai Parparita.
    
            Ensure loading has stopped in HistoryController::goToItem
            https://bugs.webkit.org/show_bug.cgi?id=54517
    
            Add a FrameLoaderClient callback for whether to stop loading before goToItem.
    
            Test: http/tests/navigation/forward-to-fragment-fires-onload.html
    
            * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
            (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
            * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    bdaa062c
FrameLoaderClientGtk.h 11.3 KB