Skip to content
  • cblu's avatar
    WebKit: · bb4427b9
    cblu authored
    	Fixed: 3116294 - Need "Reload" feature in Downloads window
    
            Reviewed by: rjw
    
            * WebKit.pbproj/project.pbxproj: made WebFramePrivate.h private so that WebBrowser can call _downloadRequest:toPath:
            * WebView.subproj/WebFramePrivate.m:
            (-[WebFrame _loadDataSource:withLoadType:]): commented out assert that complains about lack of WebView. Long-term solution is to catch this earlier and have a lone datasource download mechanism 3118355.
    
    WebBrowser:
    
    	Fixed: 3116294 - Need "Reload" feature in Downloads window
    
    	Added new download button art.
    
            Reviewed by: sullivan & darin
    
            * DownloadMonitor.h:
            * DownloadMonitor.m:
            (-[DownloadMonitor init]): create new dictionary _reloadingDataSourceToEntry that store pointers of dataSources to entries so the download monitor knows which entry started the reload.
            (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]): check if this is a reload by checking _reloadingDataSourceToEntry
            (-[DownloadMonitor setEntry:forReloadingDataSource:]): new, called by the entry to set itself as a reloading downlaod
            * DownloadProgressEntry.h:
            * DownloadProgressEntry.m:
            (-[DownloadProgressEntry _setController:]): new, for when a controller is created for reload
            (-[DownloadProgressEntry _setDataSource:]): tweak
            (-[DownloadProgressEntry _setRequest:]): new, need to retain the request so it can be used for reload
            (-[DownloadProgressEntry _setStartDate:]): new, allows to set the date more then just once
            (-[DownloadProgressEntry dealloc]): release the request and controller
            (-[DownloadProgressEntry reload]): make a controller, set it up, start download, reset the entry
            (-[DownloadProgressEntry setDone:]): release the controller because it won't be needed
            * DownloadRow.h:
            * DownloadRow.m:
            (-[DownloadRow _repositionSubviews]): new, moves widgets around
            (-[DownloadRow _setButtonAttributes]): new, sets attributes of the button
            (-[DownloadRow _startProgressAnimation]): simplified, just deal with progress bar
            (-[DownloadRow _startDiskCopyAnimation]): simplified, just deal with progress bar
            (-[DownloadRow _stopProgressAnimation]): simplified, just deal with progress bar
            (-[DownloadRow _updateStage]): call _repositionSubviews and _setButtonAttributes
            (-[DownloadRow awakeFromNib]): save the origins of the widgets
            (-[DownloadRow reload:]): call [entry reload]
            * English.lproj/Localizable.strings:
            * ResourceProgressEntry.m:
            (-[ResourceProgressEntry setBytesLoaded:]): remove error, added comment
            * Resources/Images/Download_Reload.tif: Added.
            * Resources/Images/Download_ReloadPressed.tif: Added.
            * Resources/Images/Download_Reveal.tif:
            * Resources/Images/Download_RevealPressed.tif:
            * Resources/Images/Download_Stop.tif:
            * Resources/Images/Download_StopPressed.tif:
            * WebBrowser.pbproj/project.pbxproj:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    bb4427b9