Skip to content
  • jer.noble@apple.com's avatar
    HTMLMediaElement should not throw an exception from setCurrentTime or fastSeek. · b96ab1a9
    jer.noble@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=124294
    
    Reviewed by Eric Carlson.
    
    Source/WebCore:
    
    Update the seek logic to match the current specification. This means removing exception
    throwing from both the .idl and the implementation.
    
    Remove the ExceptionCode parameter from setCurrentTime and fastSeek:
    * html/HTMLMediaElement.cpp:
    (HTMLMediaElement::fastSeek):
    (HTMLMediaElement::seek):
    (HTMLMediaElement::seekWithTolerance):
    (HTMLMediaElement::setCurrentTime):
    * html/HTMLMediaElement.h:
    * html/HTMLMediaElement.idl:
    * html/MediaController.cpp:
    (MediaController::setCurrentTime):
    * html/MediaController.h:
    * html/MediaController.idl:
    * html/MediaControllerInterface.h:
    
    Do not pass in an ExceptionCode placeholder when calling seek:
    * html/HTMLMediaElement.cpp:
    (HTMLMediaElement::rewind):
    (HTMLMediaElement::returnToRealtime):
    (HTMLMediaElement::finishSeek):
    (HTMLMediaElement::playInternal):
    (HTMLMediaElement::mediaPlayerTimeChanged):
    (HTMLMediaElement::mediaPlayerDurationChanged):
    (HTMLMediaElement::applyMediaFragmentURI):
    * html/HTMLMediaElement.h:
    * html/HTMLMediaElement.idl:
    * html/MediaController.cpp:
    (MediaController::bringElementUpToSpeed):
    * html/MediaController.h:
    * html/MediaController.idl:
    * html/MediaControllerInterface.h:
    * html/shadow/MediaControlElementTypes.cpp:
    (WebCore::MediaControlSeekButtonElement::seekTimerFired):
    * html/shadow/MediaControlElements.cpp:
    (WebCore::MediaControlRewindButtonElement::defaultEventHandler):
    (WebCore::MediaControlTimelineElement::defaultEventHandler):
    * platform/mac/WebVideoFullscreenHUDWindowController.mm:
    (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
    
    LayoutTests:
    
    * media/video-seek-no-src-exception-expected.txt: Removed.
    * media/video-seek-no-src-exception.html: Removed.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b96ab1a9