-
darin authored
- test http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves * editing/selection/move-by-character-6.html: Added. * editing/selection/move-by-character-6-expected.txt: Added. * editing/selection/move-by-character-6-expected.checksum: Added. * editing/selection/move-by-character-6-expected.png: Added. WebCore: Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves Test: editing/selection/move-by-character-6.html The trick was to draw the focus ring clipped to a list of rectangles instead of clipped to exactly one. * kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing. * kwq/KWQPainter.mm: (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from an NSBezierPath to a CGMutablePathRef. (WebCore::QPainterPrivate::~QPainterPrivate): Ditto. (WebCore::QPainter::initFocusRing): Removed color parameter, and made a CGPath instead of an NSBezierPath. (WebCore::QPainter::addFocusRingRect): CGPath instead of NSBezierPath. (WebCore::QPainter::drawFocusRing): Added color parameter, and changed to use new bridge method to draw the focus ring. (WebCore::QPainter::clearFocusRing): CGPath instead of NSBezierPath. * kwq/WebCoreGraphicsBridge.h: * kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:]): Replaced setFocusRingStyle: method with this one. * rendering/render_flow.cpp: (WebCore::RenderFlow::paintFocusRing): * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): Pass color to drawFocusRing instead of initFocusRing. - fixed message on exit from the other patch I just landed * platform/mac/CursorMac.mm: (WebCore::leakNamedCursor): Renamed and made this leak intentionally. WebKit: Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this. - WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves * WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:]): Replaced the old bridge function that set up style with this one that renders a path. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
darin authored- test http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves * editing/selection/move-by-character-6.html: Added. * editing/selection/move-by-character-6-expected.txt: Added. * editing/selection/move-by-character-6-expected.checksum: Added. * editing/selection/move-by-character-6-expected.png: Added. WebCore: Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves Test: editing/selection/move-by-character-6.html The trick was to draw the focus ring clipped to a list of rectangles instead of clipped to exactly one. * kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing. * kwq/KWQPainter.mm: (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from an NSBezierPath to a CGMutablePathRef. (WebCore::QPainterPrivate::~QPainterPrivate): Ditto. (WebCore::QPainter::initFocusRing): Removed color parameter, and made a CGPath instead of an NSBezierPath. (WebCore::QPainter::addFocusRingRect): CGPath instead of NSBezierPath. (WebCore::QPainter::drawFocusRing): Added color parameter, and changed to use new bridge method to draw the focus ring. (WebCore::QPainter::clearFocusRing): CGPath instead of NSBezierPath. * kwq/WebCoreGraphicsBridge.h: * kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:]): Replaced setFocusRingStyle: method with this one. * rendering/render_flow.cpp: (WebCore::RenderFlow::paintFocusRing): * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): Pass color to drawFocusRing instead of initFocusRing. - fixed message on exit from the other patch I just landed * platform/mac/CursorMac.mm: (WebCore::leakNamedCursor): Renamed and made this leak intentionally. WebKit: Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this. - WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves * WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:]): Replaced the old bridge function that set up style with this one that renders a path. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading