Skip to content
  • leviw@chromium.org's avatar
    Update localSelectionRect to return a LayoutRect · b43991f8
    leviw@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=82183
    
    Reviewed by Eric Seidel.
    
    localSelectionRect returns a rectangle in the coordinate space of its renderer,
    and therefor should remain LayoutUnits until being promoted to absolute
    coordinates or painted. Also fixing an incorrect conversion of startPos and
    endPos in selectionRectForRepaint.
    
    No new tests. No change in behavior.
    
    * rendering/InlineTextBox.cpp:
    (WebCore::InlineTextBox::localSelectionRect): Continuing to use enclosingIntRect
    for the value being returned from the font engine since these floating point
    values should not be pixel snapped.
    * rendering/InlineTextBox.h:
    (InlineTextBox):
    * rendering/RenderReplaced.cpp:
    (WebCore::RenderReplaced::localSelectionRect):
    * rendering/RenderReplaced.h:
    (RenderReplaced):
    * rendering/RenderText.cpp:
    (WebCore::localQuadForTextBox):
    (WebCore::RenderText::absoluteRectsForRange):
    (WebCore::RenderText::absoluteQuadsForRange):
    (WebCore::RenderText::selectionRectForRepaint): Fixing an incorrect conversion of
    start/endPos to LayoutUnits. These values represent a range of selected characters,
    not layout values!
    * rendering/svg/RenderSVGInlineText.cpp:
    (WebCore::RenderSVGInlineText::localCaretRect):
    * rendering/svg/SVGInlineTextBox.cpp:
    (WebCore::SVGInlineTextBox::localSelectionRect):
    * rendering/svg/SVGInlineTextBox.h:
    (SVGInlineTextBox):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b43991f8