Skip to content
  • eric@webkit.org's avatar
    2009-10-23 Alpha Lam <hclam@chromium.org> · b3328a12
    eric@webkit.org authored
            Reviewed by Eric Carlson.
    
            Volume slider always starts at half volume
            https://bugs.webkit.org/show_bug.cgi?id=28322
    
            * media/video-volume-slider.html: Added.
            Pixel test for the volume slider of the media control. This test
            assumes volume slider is implemented and usable. It moves the mouse
            over the right bottom corner of a video element to trigger the
            volume slider. If volume slider is not implemented at all, you'll
            only see a video element with the first frame.
            * platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
            * platform/mac/Skipped: ditto.
            * platform/win/Skipped: ditto.
    2009-10-23  Alpha Lam  <hclam@chromium.org>
    
            Reviewed by Eric Carlson.
    
            Volume slider always starts at half volume
            https://bugs.webkit.org/show_bug.cgi?id=28322
    
            Sets the value attribute of volume slider to the volume attribute
            of the media element. Also update the value attribute of the
            input element for the volume slider when the volume attribute
            of the media element is updated.
    
            Test: media/video-volume-slider.html
    
            * rendering/MediaControlElements.cpp:
            (WebCore::MediaControlVolumeSliderElement::update):
            Set the value attribute of the input element for the volume slider
            using the current volume of the media element.
            * rendering/MediaControlElements.h:
            Add method definition of update().
            * rendering/RenderMedia.cpp:
            (WebCore::RenderMedia::createVolumeSlider):
            Creates a volume slider with value attribute equals to the current
            volume attribute of the media element.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b3328a12