-
haraken@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76970 Reviewed by Adam Barth. I've been trying to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836), but the approach was wrong. This patch invalidates patches committed in r105697, r105766, r105809 and r105805. In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm so that they overwrite .h/.cpp files only when the bytes differ. By this fix, we were able to stop rebuilding .h/.cpp files that are not changed. However, the fix has made generate-bindings.pl run for almost all IDLs every time. The reason is as follows: (0) Assume that there are A.idl, B.idl and C.idl. (1) Modify A.idl. (2) First build. (3) supplemental_dependency.tmp is updated. (4) generate-bindings.pl runs for A.idl, B.idl and C.idl. (5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated. (6) Second build. (7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl. (8) B.h, B.cpp, C.h and C.cpp are not updated. (9) Third build. (10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl. (11) B.h, B.cpp, C.h and C.cpp are not updated. ... We should fix the bug somehow, but how to fix it is not obvious. For the time being, this patch invalidates r105697, r105766, r105809 and r105805. No tests. No change in behavior. * bindings/scripts/CodeGenerator.pm: (UpdateFile): * bindings/scripts/CodeGeneratorCPP.pm: (WriteData): * bindings/scripts/CodeGeneratorJS.pm: (WriteData): * bindings/scripts/CodeGeneratorObjC.pm: (WriteData): * bindings/scripts/CodeGeneratorV8.pm: (WriteData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
b2ce0673