Skip to content
  • commit-queue@webkit.org's avatar
    [css3-text] Add CSS3 Text decoration compile flag · b0d2763f
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=93863
    
    Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-15
    Reviewed by Julien Chaffraix.
    
    This patch handles the compile flag implementation, which will come disabled by
    default, thus not exposing the CSS3 text decoration features to the web, unless
    when explicitly enabling it with "--css3-text-decoration" build parameter.
    
    .:
    
    * Source/cmake/WebKitFeatures.cmake:
    * Source/cmakeconfig.h.cmake:
    * configure.ac:
    
    Source/JavaScriptCore:
    
    * Configurations/FeatureDefines.xcconfig:
    
    Source/WebCore:
    
    Changeset r125205 added "-webkit-text-decoration-line" support without proper
    compile flag. I am fixing this on this patch by adding #ifdef's along the added
    code and reverting getComputedStyle* layout test changes until further notice.
    The text-decoration-line.html layout test is now moved to
    fast/css3-text-decoration directory, which is skipped on all platforms until
    feature is sound and ready to be exposed to web.
    
    Test: fast/css3-text-decoration/text-decoration-line.html
    
    * Configurations/FeatureDefines.xcconfig:
    * GNUmakefile.am:
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
    * css/CSSParser.cpp:
    (WebCore::CSSParser::parseValue):
    (WebCore::CSSParser::addTextDecorationProperty):
    (WebCore::CSSParser::parseTextDecoration):
    * css/CSSProperty.cpp:
    (WebCore::CSSProperty::isInheritedProperty):
    * css/CSSPropertyNames.in:
    * css/StyleBuilder.cpp:
    (WebCore::StyleBuilder::StyleBuilder):
    * css/StyleResolver.cpp:
    (WebCore::StyleResolver::collectMatchingRulesForList):
    Added #ifdefs to enable/disable CSS3 Text Decoration code implemented by r125205.
    
    Source/WebKit/chromium:
    
    * features.gypi:
    
    Source/WebKit/mac:
    
    * Configurations/FeatureDefines.xcconfig:
    
    Source/WebKit2:
    
    * Configurations/FeatureDefines.xcconfig:
    
    Tools:
    
    * Scripts/webkitperl/FeatureList.pm:
    * qmake/mkspecs/features/features.pri:
    
    WebKitLibraries:
    
    * win/tools/vsprops/FeatureDefines.vsprops:
    * win/tools/vsprops/FeatureDefinesCairo.vsprops:
    
    LayoutTests:
    
    Changeset r125205 added "-webkit-text-decoration-line" support without proper
    compile flag. I am fixing this on this patch by adding #ifdef's along the added
    code and reverting getComputedStyle* layout test changes until further notice.
    The text-decoration-line.html layout test is now moved to
    fast/css3-text-decoration directory, which is skipped on all platforms until
    feature is sound and ready to be exposed to web.
    
    * fast/css/getComputedStyle/computed-style-expected.txt:
    * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
    * fast/css/getComputedStyle/resources/property-names.js:
    * svg/css/getComputedStyle-basic-expected.txt:
    Avoid regression by reverting changes from r125205.
    * fast/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css/text-decoration-line-expected.html.
    * fast/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css/text-decoration-line.html.
    * platform/chromium/TestExpectations:
    * platform/efl/TestExpectations:
    * platform/gtk/TestExpectations:
    * platform/mac/TestExpectations:
    * platform/qt/TestExpectations:
    * platform/win/TestExpectations:
    fast/css3-text-decoration directory is skipped until feature is enabled by default.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b0d2763f