Skip to content
  • mitz@apple.com's avatar
    WebCore: · af63be9e
    mitz@apple.com authored
            Reviewed by Anders Carlsson.
    
            - fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a
              Google map in iPhoto Places, it drags a map tile instead
    
            Calling stopLoadRequest() from notifyFinished() removed the
            ScriptElementData from the CachedScript's client set, which could make
            it eligible for purging. The fix is to call removeClient() only after
            executing the script, which protects it from being purged while it is
            in the document's queue of scripts to execute soon.
    
            * dom/ScriptElement.cpp:
            (WebCore::ScriptElementData::execute): Call removeClient() here.
            (WebCore::ScriptElementData::notifyFinished): Instead of calling
            stopLoadRequest(), which calls removeClient(), just reset
            m_cachedScript.
    
    WebKitTools:
    
            Reviewed by Adele Peterson.
    
            - add a LayoutTestController method for temporarily changing the WebKit
              cache model
    
            * DumpRenderTree/LayoutTestController.cpp:
            (setCacheModelCallback): Added. Calls
            LayoutTestController::setCacheModel() with the first argument as an
            integer.
            (LayoutTestController::staticFunctions): Added setCacheModel.
            * DumpRenderTree/LayoutTestController.h:
            * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
            (LayoutTestController::setCacheModel):
            * DumpRenderTree/mac/DumpRenderTree.mm:
            (setDefaultsToConsistentValuesForTesting): Reset the cache model to
            WebCacheModelDocumentBrowser.
            * DumpRenderTree/mac/LayoutTestControllerMac.mm:
            (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences
            setCacheModel:].
            * DumpRenderTree/win/LayoutTestControllerWin.cpp:
            (LayoutTestController::setCacheModel):
            * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
            (LayoutTestController::setCacheModel):
    
    LayoutTests:
    
            Reviewed by Adele Peterson.
    
            - updated test to cover <rdar://problem/6958664> REGRESSION (r42665):
              When I drag to pan a Google map in iPhoto Places, it drags a map tile
              instead
    
            * fast/dom/HTMLScriptElement/nested-execution.html:
            * fast/dom/HTMLScriptElement/resources/nested-execution.js:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    af63be9e