-
benm@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=29040 Patch by Steve Block <steveblock@google.com> on 2009-09-10 Reviewed by Darin Adler. Tests: fast/dom/Geolocation/reentrant-error.html fast/dom/Geolocation/reentrant-success.html * page/Geolocation.cpp: Modified. (WebCore::Geolocation::handleError): Modified. Call sendError directly, clearing notifier lists before making callback. (WebCore::Geolocation::makeSuccessCallbacks): Modified. Call sendPosition directly, clearing notifier lists before making callback. * page/Geolocation.h: Modified. Deleted sendErrorToXX and sendPositionToXXX methods. LayoutTests: Geolocation does not correctly handle reentrant calls from callbacks. https://bugs.webkit.org/show_bug.cgi?id=29040 Patch by Steve Block <steveblock@google.com> on 2009-09-09 Reviewed by Darin Adler. * fast/dom/Geolocation/resources/reentrant-error.js: Added. Tests that reentrant calls from the error callback are OK. * fast/dom/Geolocation/reentrant-error.html: Added. Wrapper for above test. * fast/dom/Geolocation/reentrant-error-expected.txt: Added. Expected result for above test. * fast/dom/Geolocation/resources/reentrant-success.js: Added. Tests that reentrant calls from the success callback are OK. * fast/dom/Geolocation/reentrant-success.html: Added. Wrapper for above test. * fast/dom/Geolocation/reentrant-success-expected.txt: Added. Expected result for above test. * platform/gtk/Skipped: Modified. Skips above tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ae2f76a0