Skip to content
  • rniwa@webkit.org's avatar
    EWS should use a human readable port name when uploading layout test archives · add4ad5b
    rniwa@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=113099
    
    Reviewed by Dirk Pranke.
    
    Use new port's object's name() method to report human readable port names.
    This will also help us resolving the bug to apply layout test results posted by EWS.
    
    * Scripts/webkitpy/tool/bot/botinfo.py:
    (BotInfo.__init__): Take port's name.
    (BotInfo.summary_text):
    
    * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
    (BotInfoTest.test_summary_text):
    
    * Scripts/webkitpy/tool/bot/flakytestreporter.py:
    (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
    
    * Scripts/webkitpy/tool/commands/queues.py:
    (PatchProcessingQueue.__init__): Initialize self._port.
    (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
    and use that for the attachment filename and the comment posted.
    
    * Scripts/webkitpy/tool/commands/queues_unittest.py:
    (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
    "mac-snowleopard" as expected for TestPort.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    add4ad5b