Skip to content
  • timothy@apple.com's avatar
    Fixes the assertion and crash that would happen when inspecting a element from a frame. · a5d0af3b
    timothy@apple.com authored
    This change makes JSInspectedObjectWrapper pass unwrapped objects around for global objects
    that share the same page group identifier. Also returns jsUndefined() instead of 0 to prevent
    crashing in release builds if the page groups don't match.
    
    Passes all the tests in: manual-tests/inspector-wrappers
    
    Reviewed by Adam Roben.
    
    * bindings/js/JSInspectedObjectWrapper.cpp:
    (WebCore::JSInspectedObjectWrapper::prepareIncomingValue): Return jsUndefined() instead of 0.
    Call allowsUnwrappedAccessFrom instead of unwrappedExecStateMatches.
    * bindings/js/JSQuarantinedObjectWrapper.cpp:
    (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Renamed from unwrappedExecStateMatches.
    Return true if the pageGroupIdentifier of both wrappers match.
    (WebCore::JSQuarantinedObjectWrapper::callAsFunction): Return jsUndefined() instead of 0.
    * bindings/js/JSQuarantinedObjectWrapper.h: Renamed unwrappedExecStateMatches to allowsUnwrappedAccessFrom.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a5d0af3b