Skip to content
  • commit-queue@webkit.org's avatar
    defining line height affects height of text box · a25166de
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=17619
    
    Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-08
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    Giving line height to input elements increase the height
    of the element. To make it work similiar as Mozilla and IE
    line-height :normal should be applied for input elements.
    
    Test: fast/dom/HTMLInputElement/input-line-height.html
    
    * css/html.css:
    (input):
    Made the line-height: normal as !important so that it does not
    consider any other line-height specified through internal or
    external styles.
    
    LayoutTests:
    
    * fast/dom/HTMLInputElement/input-line-height-expected.txt: Added.
    * fast/dom/HTMLInputElement/input-line-height.html: Added.
    
    Added new test for verifying that giving line-height to input element
    has no affect on its height.
    
    * fast/forms/placeholder-position-expected.txt:
    * platform/mac/fast/forms/placeholder-position-expected.png:
    
    Rebaselining existing tests as per the new behavior. The position
    of input elements have been modified since line-height is not being
    considered.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a25166de