Skip to content
  • benjamin@webkit.org's avatar
    Remove the memory instrumentation code · 9d72cb0b
    benjamin@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=114931
    
    Reviewed by Andreas Kling.
    
    .: 
    
    * Source/autotools/symbols.filter:
    
    Source/JavaScriptCore: 
    
    * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
    * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
    
    Source/WebCore: 
    
    The Memory Instrumentation code is unfinished and has already
    become out of sync the objects it is supposed to represent.
    
    The current approach does not seem maintainable, it is better to
    remove it before someone gets hurt.
    
    By removing the code, the binary become 1240976 bytes smaller.
    Yep, almost 1 Mb, bringing WebCore to the size it has 5 months ago :)
    
    * MostWebCoreFiles: remove the support for memory instrumentation.
    
    Source/WebKit: 
    
    * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
    
    Source/WebKit/mac: 
    
    * WebView/WebRenderLayer.mm:
    
    Source/WebKit/win: 
    
    * WebKit.vcproj/WebKitExports.def.in:
    
    Source/WTF: 
    
    On Mac x86_64, the code removal cause the binary to be
    9224 bytes smaller.
    
    * GNUmakefile.list.am:
    * WTF.pro:
    * WTF.vcproj/WTF.vcproj:
    * WTF.vcxproj/WTF.vcxproj:
    * WTF.vcxproj/WTF.vcxproj.filters:
    * WTF.xcodeproj/project.pbxproj:
    * wtf/CMakeLists.txt:
    * wtf/Forward.h:
    * wtf/ListHashSet.h:
    (ListHashSet):
    (ListHashSetNodeAllocator):
    (WTF::ListHashSetNodeAllocator::pool):
    (WTF::ListHashSetNodeAllocator::pastPool):
    * wtf/MemoryInstrumentation.cpp: Removed.
    * wtf/MemoryInstrumentation.h: Removed.
    * wtf/MemoryInstrumentationArrayBufferView.h: Removed.
    * wtf/MemoryInstrumentationHashCountedSet.h: Removed.
    * wtf/MemoryInstrumentationHashMap.h: Removed.
    * wtf/MemoryInstrumentationHashSet.h: Removed.
    * wtf/MemoryInstrumentationListHashSet.h: Removed.
    * wtf/MemoryInstrumentationSequence.h: Removed.
    * wtf/MemoryInstrumentationString.h: Removed.
    * wtf/MemoryInstrumentationVector.h: Removed.
    * wtf/MemoryObjectInfo.h: Removed.
    * wtf/text/AtomicString.h:
    * wtf/text/StringImpl.h:
    (WTF::StringImpl::isASCIILiteral):
    * wtf/text/WTFString.h:
    
    Tools: 
    
    * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
    * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.
    
    LayoutTests: 
    
    * inspector/profiler/memory-instrumentation-cached-images-expected.txt: Removed.
    * inspector/profiler/memory-instrumentation-cached-images.html: Removed.
    * inspector/profiler/memory-instrumentation-canvas-expected.txt: Removed.
    * inspector/profiler/memory-instrumentation-canvas.html: Removed.
    * inspector/profiler/memory-instrumentation-external-array-expected.txt: Removed.
    * inspector/profiler/memory-instrumentation-external-array.html: Removed.
    * inspector/profiler/memory-instrumentation-external-string-expected.txt: Removed.
    * inspector/profiler/memory-instrumentation-external-string.html: Removed.
    * inspector/profiler/memory-instrumentation-test.js: Removed.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9d72cb0b