Skip to content
  • rniwa@webkit.org's avatar
    REGRESSION(r150187): Safari fails to render allrecipe.com comment popups · 9cdeefb1
    rniwa@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=119780
    
    Reviewed by Benjamin Poulain.
    
    Source/WebCore: 
    
    The bug was caused by SelectorDataList::executeFastPathForIdSelector not verifying that
    elements found by getAllElementsById are descendents of rootNode when there are multiple
    elements of the same id. This resulted in querySelector and querySelectorAll of an element
    returning nodes outside of the element.
    
    Fixed the bug by checking this condition when we have multiple elements of the same id.
    
    Test: fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html
    
    * dom/SelectorQuery.cpp:
    (WebCore::SelectorDataList::executeFastPathForIdSelector):
    
    LayoutTests: 
    
    * fast/selectors/querySelector-id-with-multiple-elements-with-same-id-expected.txt: Added.
    * fast/selectors/querySelector-id-with-multiple-elements-with-same-id.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9cdeefb1