Skip to content
  • commit-queue@webkit.org's avatar
    [WK2] Page reloading will crash UIProcess after WebProcess was killed · 994a2a11
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=109305
    
    Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-12
    Reviewed by Benjamin Poulain.
    
    Source/WebKit2:
    
    Re-initialize the pointer to a WebInspectorProxy object before calling
    initializeWebPage().
    
    When the WebProcess crashes, WebPageProxy::processDidCrash() will
    set WebInspectorProxy pointer to null, which later is accessed by
    initializeWebPage(). This patch avoids a crash scenario where
    calls into a null pointer would be made.
    
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::reattachToWebProcess):
    
    Tools:
    
    Adding a new test to simulate the case of WebProcess crash followed by a trying
    to load a new page.
    
    * TestWebKitAPI/GNUmakefile.am:
    * TestWebKitAPI/PlatformEfl.cmake:
    * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
    * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
    (TestWebKitAPI):
    (TestWebKitAPI::didFinishLoad):
    (TestWebKitAPI::TEST):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    994a2a11