Skip to content
  • kent.hansen@nokia.com's avatar
    2010-09-07 Kent Hansen <kent.hansen@nokia.com> · 8f8acc93
    kent.hansen@nokia.com authored
            Reviewed by Andreas Kling.
    
            [Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because __qt_sender__ is never set
            https://bugs.webkit.org/show_bug.cgi?id=44697
    
            When the signal handler is a JS function, __qt_sender__ is stuffed into a temporary
            object that's pushed onto the function's scope before the function is invoked, and
            popped again afterwards.
    
            We were pushing this new scope object _after_ calling JSFunction::getCallData(),
            and relying on JSC::call() to use the fresh scope chain from the function object.
            However, this is no longer the case; JSC::call() uses the scope chain passed in
            the CallData argument. Hence, we need to set up the scope before the function's
            CallData is queried.
    
            * bridge/qt/qt_runtime.cpp:
            (JSC::Bindings::QtConnectionObject::execute):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8f8acc93