Skip to content
  • mrobinson@webkit.org's avatar
    2011-05-31 Martin Robinson <mrobinson@igalia.com> · 8e67bae7
    mrobinson@webkit.org authored
            Reviewed by Ryosuke Niwa.
    
            [GTK] Support smart replace for the pasteboard
            https://bugs.webkit.org/show_bug.cgi?id=61734
    
            Unskip tests which are now passing and update results for other tests
            which vary depending on smart replace support.
    
            * platform/gtk/Skipped: Unskip tests which are now passing.
            * platform/gtk/editing/deleting/smart-delete-003-expected.txt:
            * platform/gtk/editing/deleting/smart-delete-004-expected.txt:
            * platform/gtk/editing/pasteboard/4944770-2-expected.txt:
            * platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
            * platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
            * platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
            * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
            * platform/gtk/fast/lists/drag-into-marker-expected.txt:
    2011-05-31  Martin Robinson  <mrobinson@igalia.com>
    
            Reviewed by Ryosuke Niwa.
    
            [GTK] Support smart replace for the pasteboard
            https://bugs.webkit.org/show_bug.cgi?id=61734
    
            Add smart replace support to WebCore and add hooks for it in WebKit
            via DumpRenderTreeSupportGtk. When a platform supports smart replace,
            WebCore will remove extra spaces that appear when pasting text. Eventually
            WebKitGTK+ may want to expose this in the public API.
    
            * platform/gtk/PasteboardGtk.cpp:
            (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace
            when calling writeSelection.
            (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard
            for whether or not it supports smart paste.
            * platform/gtk/PasteboardHelper.cpp:
            (WebCore::initGdkAtoms): Added initialization for smart replace atom.
            (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom.
            (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter.
            (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter.
            (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
            * platform/gtk/PasteboardHelper.h: Add new method definition.
    2011-05-31  Martin Robinson  <mrobinson@igalia.com>
    
            Reviewed by Ryosuke Niwa.
    
            [GTK] Support smart replace for the pasteboard
            https://bugs.webkit.org/show_bug.cgi?id=61734
    
            Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
            smart replace in the tests.
    
            * WebCoreSupport/DragClientGtk.cpp:
            (WebKit::DragClient::startDrag): targeListForDataObject now takes another
            parameter determining whether or not to add smart paste support. Add it here.
            * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
            (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
            * WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
            * WebCoreSupport/EditorClientGtk.cpp:
            (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation.
            (WebKit::EditorClient::smartInsertDeleteEnabled): Added.
            (WebKit::EditorClient::EditorClient):
            * WebCoreSupport/EditorClientGtk.h: Add new method definition.
    2011-05-31  Martin Robinson  <mrobinson@igalia.com>
    
            Reviewed by Ryosuke Niwa.
    
            [GTK] Support smart replace for the pasteboard
            https://bugs.webkit.org/show_bug.cgi?id=61734
    
            Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
            This is required to produce consistent test results.
    
            * DumpRenderTree/gtk/DumpRenderTree.cpp:
            (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
            * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
            (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
            methods which calls into DumpRenderTreeSupportGtk.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8e67bae7