Skip to content
  • commit-queue@webkit.org's avatar
    [EFL][WK2] Remove some C'ism from EwkView · 8ad4d36c
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=100370
    
    Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-25
    Reviewed by Kenneth Rohde Christiansen.
    
    Source/WebKit2:
    
    Remove a lot of C'ism from EwkView:
    - Make more members private and add C++ methods to
    EwkViewImpl for the public C API to use
    - Use smart pointers when possible instead of raw
    ones
    - Use C++ naming conventions for callback functions
    and define them as static methods in EwkViewImpl.
    
    * UIProcess/API/efl/EwkViewImpl.cpp:
    (EwkViewImpl::onIMFInputSequenceComplete):
    (EwkViewImpl::onIMFPreeditSequenceChanged):
    (EwkViewImpl::createIMFContext):
    (EwkViewImpl::EwkViewImpl):
    (EwkViewImpl::~EwkViewImpl):
    (EwkViewImpl::setCursor):
    (EwkViewImpl::setColorPickerColor):
    (EwkViewImpl::isFocused):
    (EwkViewImpl::isVisible):
    (EwkViewImpl::title):
    (EwkViewImpl::inputMethodContext):
    (EwkViewImpl::themePath):
    (EwkViewImpl::setThemePath):
    (EwkViewImpl::customTextEncodingName):
    (EwkViewImpl::setCustomTextEncodingName):
    (EwkViewImpl::setMouseEventsEnabled):
    (EwkViewImpl::setTouchEventsEnabled):
    (EwkViewImpl::informIconChange):
    (EwkViewImpl::requestColorPicker):
    (EwkViewImpl::dismissColorPicker):
    (EwkViewImpl::updateTextInputState):
    (EwkViewImpl::informURLChange):
    (EwkViewImpl::onMouseDown):
    (EwkViewImpl::onMouseUp):
    (EwkViewImpl::onMouseMove):
    (EwkViewImpl::feedTouchEvents):
    (EwkViewImpl::onTouchDown):
    (EwkViewImpl::onTouchUp):
    (EwkViewImpl::onTouchMove):
    * UIProcess/API/efl/EwkViewImpl.h:
    (WebCore):
    (EwkViewImpl::ewkContext):
    (EwkViewImpl::settings):
    (EwkViewImpl):
    (EwkViewImpl::url):
    (EwkViewImpl::faviconURL):
    (EwkViewImpl::mouseEventsEnabled):
    (EwkViewImpl::touchEventsEnabled):
    * UIProcess/API/efl/PageClientImpl.cpp:
    (WebKit::PageClientImpl::isViewFocused):
    (WebKit::PageClientImpl::isViewVisible):
    (WebKit::PageClientImpl::didRelaunchProcess):
    (WebKit::PageClientImpl::handleDownloadRequest):
    * UIProcess/API/efl/ewk_settings_private.h:
    (Ewk_Settings::create):
    (Ewk_Settings::Ewk_Settings):
    (Ewk_Settings):
    * UIProcess/API/efl/ewk_view.cpp:
    (_ewk_view_smart_mouse_up):
    (_ewk_view_smart_key_down):
    (_ewk_view_smart_add):
    (ewk_view_context_get):
    (ewk_view_url_get):
    (ewk_view_icon_url_get):
    (ewk_view_settings_get):
    (ewk_view_title_get):
    (ewk_view_theme_set):
    (ewk_view_theme_get):
    (ewk_view_setting_encoding_custom_get):
    (ewk_view_setting_encoding_custom_set):
    (ewk_view_mouse_events_enabled_set):
    (ewk_view_mouse_events_enabled_get):
    (ewk_view_color_picker_color_set):
    (ewk_view_touch_events_enabled_set):
    (ewk_view_touch_events_enabled_get):
    * UIProcess/efl/WebInspectorProxyEfl.cpp:
    (WebKit::WebInspectorProxy::platformCreateInspectorPage):
    
    Source/WTF:
    
    Make OwnPtr useable for Ecore_IMF_Context to avoid
    using raw pointers in EFL port.
    
    * wtf/OwnPtrCommon.h:
    (WTF):
    * wtf/PlatformEfl.cmake:
    * wtf/efl/OwnPtrEfl.cpp:
    (WTF::deleteOwnedPtr):
    (WTF):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8ad4d36c