Skip to content
  • darin@apple.com's avatar
    WebCore: · 89c61adc
    darin@apple.com authored
            Reviewed by Kevin Decker.
    
            - added an assertion for a situation that leads to a Safari assertion:
              a commit that is not followed by a load completion
    
            - removed some unneeded FrameLoader stuff -- maybe some day we'll get this
              class cut down to size
    
            * loader/FrameLoader.cpp:
            (WebCore::FrameLoader::FrameLoader): Added boolean for assertion.
            (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert
            that we already sent a commit before sending a complete.
            (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call
            client directly instead of indirecting through a function.
            (WebCore::FrameLoader::loadItem): Ditto.
            (WebCore::FrameLoader::goToItem): Ditto.
            (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing
            state from Settings instead of FrameLoaderClient. Also call client directly
            instead of indirecting through a function.
            (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead
            of indirecting through a function.
            (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert
            that we did not yet send a commit and set the flag that will be used to check
            that we don't do this twice in a row without an intervening completion call.
    
            * loader/FrameLoader.h: Added a boolean for the assertion. Removed six
            now-unneeded functions.
    
            * loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.
    
            * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get
            the private browsing state from Settings instead of FrameLoaderClient.
    
            * svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.
    
    WebKit/gtk:
    
            Reviewed by Kevin Decker.
    
            * WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
            * WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
    
    WebKit/mac:
    
            Reviewed by Kevin Decker.
    
            * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
            * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
            * WebKit.order: Ditto.
    
    WebKit/qt:
    
            Reviewed by Kevin Decker.
    
            * WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
            * WebCoreSupport/FrameLoaderClientQt.h: Ditto.
    
    WebKit/win:
    
            Reviewed by Kevin Decker.
    
            * WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
            * WebFrame.h: Ditto.
    
    WebKit/wx:
    
            Reviewed by Kevin Decker.
    
            * WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
            * WebKitSupport/FrameLoaderClientWx.h: Ditto.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    89c61adc