Skip to content
  • sullivan's avatar
    WebKit: · 8518f7bc
    sullivan authored
            * Misc.subproj/WebNSViewExtras.h:
            * Misc.subproj/WebNSViewExtras.m:
            (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]):
    	new method
            (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]):
    	now calls the new method, passing the default hysteresis values
    
    WebBrowser:
    
    	- fixed 3096528 -- don't let initially-horizontal drags of
    	toolbar bookmarks escape from toolbar
    
    	Unfortunately I left behind a drawing glitch, recorded as
    	bug 3099488. Ideas to fix this are hereby solicited.
    
            * FavoritesBar.m:
            (-[FavoritesBar slideButtonsIntoPlace]):
    	renamed from repositionButtons for clarity
            (-[FavoritesBar maxButtonX]):
    	new method, extracted from _layOutButtons
            (-[FavoritesBar _layOutButtons]):
    	now calls maxButtonX
            (-[FavoritesBar setDropIndex:]):
    	updated for name change
            (-[FavoritesBar specialBookmarkSourcesCount]):
    	new method, extracted from duplicated code
            (-[FavoritesBar lastNonFavoriteIndex]):
    	new method, extracted from dropIndexFromDraggingInfo:
            (-[FavoritesBar dropIndexFromLocalPoint:]):
    	new method, extracted from dropIndexFromDraggingInfo:
            (-[FavoritesBar dropIndexFromDraggingInfo:]):
    	now calls dropIndexFromLocalPoint:
            (-[FavoritesBar addDroppedBookmarks:atIndex:]):
    	new method, extracted from performDragOperation:
            (-[FavoritesBar performDragOperation:]):
    	now calls addDroppedBookmarks:atIndex:
            (-[FavoritesBar _lastDraggedEventFollowing:]),
            (-[FavoritesBar _lastDraggedOrUpEventFollowing:]):
    	new methods, cribbed from AppKit
            (-[FavoritesBar constrainProposedButtonFrame:]):
    	new method
            (-[FavoritesBar reorderFavoriteButton:fromMouseDownEvent:]):
    	new method, drags (but not using CoreDragging stuff) button
    	horizontally within bar only
    
            * FavoritesBarView.h:
    	added definition of FavoritesBarReorderingDelegate informal protocol
            * FavoritesBarView.m:
            (-[FavoritesBarView reorderFavoriteButton:fromMouseDownEvent:]):
    	pass call through to delegate (FavoritesBar)
    
            * FavoriteButton.m:
            (-[FavoriteButton currentEventOffsetFromEvent:]):
    	new method, extracted from performDragFromEvent:
            (-[FavoriteButton performDragFromEvent:]):
    	now calls extracted method
            (-[FavoriteButton canDrag]):
    	renamed from canDragButton; now checks whether superview is a
    	FavoritesBarView
            (-[FavoriteButton mouseDown:]):
    	checks whether initial dragging movement was primarily vertical or
    	horizontal; if horizontal, calls new reordering code; if vertical,
    	uses larger hysteresis to minimize accidental poofing
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8518f7bc