• caio.oliveira@openbossa.org's avatar
    2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> · 7c27c0df
    caio.oliveira@openbossa.org authored
            Reviewed by Andreas Kling.
    
            [Qt] tst_QWebFrame::overloadedSlots() fails
            https://bugs.webkit.org/show_bug.cgi?id=37319
    
            This patch is based on Noam Rosenthal original patch in the same bug.
    
            When hinted with QWebElement metatype, we qualify the conversion
            from JSElement as a "perfect match".
    
            The test was failing because the wrong slot was called, since the QWebElement
            match was taken as equal to the others and not chosen when the metacall happened.
    
            * bridge/qt/qt_runtime.cpp:
            (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement
            to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason
            why we have the implicit conversion.
    2011-06-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
    
            Reviewed by Andreas Kling.
    
            [Qt] tst_QWebFrame::overloadedSlots() fails
            https://bugs.webkit.org/show_bug.cgi?id=37319
    
            * tests/qwebframe/tst_qwebframe.cpp:
            (tst_QWebFrame::overloadedSlots): Remove expected failure and
            fix the comment.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7c27c0df
qt_runtime.cpp 71.5 KB