Skip to content
  • ap's avatar
    Reviewed by Darin. · 7a07131a
    ap authored
            http://bugs.webkit.org/show_bug.cgi?id=15847
            Some editing cleanup
    
            No change in functionality.
    
    WebCore:
            * editing/TextIterator.cpp:
            (WebCore::plainText):
            * editing/TextIterator.h:
            Made WebCore::plainText() return String instead of DeprecatedString.
    
            * bridge/mac/WebCoreAXObject.mm:
            (-[WebCoreAXObject textUnderElement]):
            (-[WebCoreAXObject value]):
            (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
            (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]):
            (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
            Updated for the above change. There is no need to explicitly convert to NSString now.
    
            * editing/EditCommand.cpp:
            (WebCore::EditCommand::EditCommand): m_startingSelection and m_endingSelection are actually
            initialized in constructor body, so the work done in initializer list was wasted.
    
            (WebCore::EditCommand::apply): Moved some stars.
            (WebCore::EditCommand::unapply): Ditto.
            (WebCore::EditCommand::reapply): Ditto.
            (WebCore::EditCommand::setStartingSelection): The loop exit condition was evaluated twice,
            removed one of the checks.
    
            * editing/SelectionController.cpp:
            (WebCore::SelectionController::toString): plainText() result type now matches what we need here.
    
            * page/mac/WebCoreFrameBridge.h:
            * page/mac/WebCoreFrameBridge.mm:
            Removed unused -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] and
            -[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:].
    
    WebKit:
            * WebView/WebHTMLView.mm:
            (-[WebHTMLView deleteToEndOfLine:]):
            (-[WebHTMLView deleteToEndOfParagraph:]):
            WebCore had a duplicate of the same logic already. We are passing a boundary value to
            a function that expects granularity, this may need to be straightened out in the future.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7a07131a