-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=17767 Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-06-28 Reviewed by Tony Chang. Source/WebCore: Fixes <frameset> frameborder and border handling. Previously we'd override the frameborder=no setting if border was set. We also treated frameborder="anything" the same as frameborder=0 since we we just converted it to a number so frameborder=yes was incorrectly treated the same as frameborder=no. Tests: fast/frames/frameset-frameborder-boolean-values.html fast/frames/frameset-frameborder-inheritance.html fast/frames/frameset-frameborder-overrides-border.html * html/HTMLFrameSetElement.cpp: Proper parsing of yes,no,1,0 values. (WebCore::HTMLFrameSetElement::parseAttribute): * html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::border): Border should be 0 if frameborder=no. LayoutTests: Add lots of tests for <frameset> frameborder and border handling. * fast/frames/frameset-frameborder-boolean-values-expected.txt: Added. * fast/frames/frameset-frameborder-boolean-values.html: Added. * fast/frames/frameset-frameborder-inheritance-expected.txt: Added. * fast/frames/frameset-frameborder-inheritance.html: Added. * fast/frames/frameset-frameborder-overrides-border-expected.txt: Added. * fast/frames/frameset-frameborder-overrides-border.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
commit-queue@webkit.org authoredhttps://bugs.webkit.org/show_bug.cgi?id=17767 Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-06-28 Reviewed by Tony Chang. Source/WebCore: Fixes <frameset> frameborder and border handling. Previously we'd override the frameborder=no setting if border was set. We also treated frameborder="anything" the same as frameborder=0 since we we just converted it to a number so frameborder=yes was incorrectly treated the same as frameborder=no. Tests: fast/frames/frameset-frameborder-boolean-values.html fast/frames/frameset-frameborder-inheritance.html fast/frames/frameset-frameborder-overrides-border.html * html/HTMLFrameSetElement.cpp: Proper parsing of yes,no,1,0 values. (WebCore::HTMLFrameSetElement::parseAttribute): * html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::border): Border should be 0 if frameborder=no. LayoutTests: Add lots of tests for <frameset> frameborder and border handling. * fast/frames/frameset-frameborder-boolean-values-expected.txt: Added. * fast/frames/frameset-frameborder-boolean-values.html: Added. * fast/frames/frameset-frameborder-inheritance-expected.txt: Added. * fast/frames/frameset-frameborder-inheritance.html: Added. * fast/frames/frameset-frameborder-overrides-border-expected.txt: Added. * fast/frames/frameset-frameborder-overrides-border.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading